packages/charted/lib/core/text_metrics/segmentation.dart - Issue 2213693002: Updated charted DEP to 0.4.X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: packages/charted/lib/core/text_metrics/segmentation.dart

Issue 2213693002: Updated charted DEP to 0.4.X (Closed) Base URL: https://github.com/dart-lang/observatory_pub_packages.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: packages/charted/lib/core/text_metrics/segmentation.dart

diff --git a/packages/charted/lib/core/text_metrics/segmentation.dart b/packages/charted/lib/core/text_metrics/segmentation.dart

index 058ac3895d5c5734f0023507702b27b987cf6daf..997099a42f2e3d14065fe82d673b9b39d9565c4b 100644

--- a/packages/charted/lib/core/text_metrics/segmentation.dart

+++ b/packages/charted/lib/core/text_metrics/segmentation.dart

@@ -185,7 +185,7 @@ int _typeForRune(int rune) {

return CODE_CATEGORY_OTHER; // Defaults to OTHER.

}

-Iterable<int> graphemeBreakIndices(String s) {

+List<int> graphemeBreakIndices(String s) {

List<int> indices = [];

int previousType = 0;

for (var iter = s.runes.iterator; iter.moveNext();) {