Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: packages/charted/lib/charts/src/chart_legend_impl.dart

Issue 2213693002: Updated charted DEP to 0.4.X (Closed) Base URL: https://github.com/dart-lang/observatory_pub_packages.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/charted/lib/charts/src/chart_legend_impl.dart
diff --git a/packages/charted/lib/charts/src/chart_legend_impl.dart b/packages/charted/lib/charts/src/chart_legend_impl.dart
index dfefbc4487a96a5d70f235bb70690454daa3cb3d..7f3389e8205fb1a354750bfdf352e2c0dc94693b 100644
--- a/packages/charted/lib/charts/src/chart_legend_impl.dart
+++ b/packages/charted/lib/charts/src/chart_legend_impl.dart
@@ -114,7 +114,7 @@ class DefaultChartLegendImpl implements ChartLegend {
_root.selectAll('.chart-legend-row').data(_items, (x) => x.hashCode),
isFirstRender = rows.length == 0;
- var enter = rows.enter.appendWithCallback((d, i, e) {
+ var enter = rows.enter.appendWithCallback((ChartLegendItem d, i, e) {
var row = Namespace.createChildElement('div', e),
color = Namespace.createChildElement('div', e)
..className = 'chart-legend-color',
@@ -125,7 +125,7 @@ class DefaultChartLegendImpl implements ChartLegend {
..className = 'chart-legend-value')
: null;
- var rowStyles = ['chart-legend-row'].toList();
+ var rowStyles = <String>['chart-legend-row'];
// If this is the first time we are adding rows,
// Update elements before adding them to the DOM.
@@ -205,5 +205,5 @@ class DefaultChartLegendImpl implements ChartLegend {
}
/// Update legend to show chart's selection and visibility.
- void _handleStateChanges(_) => _createLegendItems();
+ void _handleStateChanges(List<ChangeRecord> _) => _createLegendItems();
}
« no previous file with comments | « packages/charted/lib/charts/src/chart_events_impl.dart ('k') | packages/charted/lib/charts/src/chart_series_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698