Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart

Issue 2213693002: Updated charted DEP to 0.4.X (Closed) Base URL: https://github.com/dart-lang/observatory_pub_packages.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
diff --git a/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart b/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
index 05623ba52a74b6956c5ce44457d585ea5eb91222..0d266759eccb8734d1ce3605b096243a26cc0771 100644
--- a/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
+++ b/packages/charted/lib/charts/cartesian_renderers/stackedbar_chart_renderer.dart
@@ -26,7 +26,11 @@ class StackedBarChartRenderer extends CartesianRendererBase {
/// Returns false if the number of dimension axes on the area is 0.
/// Otherwise, the first dimension scale is used to render the chart.
@override
- bool prepare(CartesianArea area, ChartSeries series) {
+ bool prepare(ChartArea area, ChartSeries series) {
+ if (area is! CartesianArea) {
+ throw new ArgumentError.value(area, 'area',
+ "ChartArea for StackedBarChartRenderer must be a CartesianArea");
+ }
_ensureAreaAndSeries(area, series);
return true;
}
@@ -89,7 +93,8 @@ class StackedBarChartRenderer extends CartesianRendererBase {
});
}
- var barWidth = dimensionScale.rangeBand - theme.defaultStrokeWidth;
+ var barWidth =
+ (dimensionScale as OrdinalScale).rangeBand - theme.defaultStrokeWidth;
// Calculate height of each segment in the bar.
// Uses prevAllZeroHeight and prevOffset to track previous segments
« no previous file with comments | « packages/charted/lib/charts/cartesian_renderers/line_chart_renderer.dart ('k') | packages/charted/lib/charts/chart_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698