Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart

Issue 2213693002: Updated charted DEP to 0.4.X (Closed) Base URL: https://github.com/dart-lang/observatory_pub_packages.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart
diff --git a/packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart b/packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart
index b05dd810c80635dc0555dadf937aafeb90230d49..65042de49eadf5a1e883d1bbb4075a119521d07d 100644
--- a/packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart
+++ b/packages/charted/lib/charts/cartesian_renderers/bubble_chart_renderer.dart
@@ -71,7 +71,7 @@ class BubbleChartRenderer extends CartesianRendererBase {
group.enter.append('g')..classed('measure-group');
group.each((d, i, e) {
e.style.setProperty('fill', color(i));
- e.attributes['data-column'] = series.measures.elementAt(i);
+ e.attributes['data-column'] = series.measures.elementAt(i).toString();
});
group.exit.remove();
@@ -85,7 +85,7 @@ class BubbleChartRenderer extends CartesianRendererBase {
'${xDimensionScale.scale(xDimensionVals[i])},'
'${yDimensionScale.scale(yDimensionVals[i])})'
..['r'] = '${bubbleRadiusScale.scale(d) * bubbleRadiusFactor}'
- ..['data-row'] = i;
+ ..['data-row'] = i.toString();
});
measures.exit.remove();
handleStateChanges([]);
@@ -107,7 +107,9 @@ class BubbleChartRenderer extends CartesianRendererBase {
@override
Extent get extent {
assert(series != null && area != null);
- var rows = area.data.rows, max = rows[0][series.measures.first], min = max;
+ var rows = area.data.rows,
+ max = rows.first[series.measures.first],
+ min = max;
rows.forEach((row) {
series.measures.forEach((idx) {

Powered by Google App Engine
This is Rietveld 408576698