Update Effective Connection Type only on main frame requests

content/browser/loader/resource_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_loader.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/location.h"
@@ skipping 72 matching lines @@
   response->head.was_fetched_via_proxy = request->was_fetched_via_proxy();
   response->head.proxy_server = response_info.proxy_server;
   response->head.socket_address = response_info.socket_address;
   const content::ResourceRequestInfo* request_info =
       content::ResourceRequestInfo::ForRequest(request);
   if (request_info)
     response->head.is_using_lofi = request_info->IsUsingLoFi();
 
   response->head.effective_connection_type =
       net::EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
-  if (info->IsMainFrame()) {
+
+  if (info->IsMainFrame() &&

[RyanSturm, 2016/08/08 18:13:37]

Is the info->IsMainFrame() part of this necessary? Seems Like
(info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME) implies
(info->IsMainFrame())

[tbansal1, 2016/08/08 18:35:25]

Done.

+      (info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME)) {

[RyanSturm, 2016/08/08 18:13:37]

#include "content/public/common/resource_type.h"

This should have already been included.

[tbansal1, 2016/08/08 18:35:25]

Done.

     net::NetworkQualityEstimator* estimator =
         request->context()->network_quality_estimator();
     if (estimator) {
       response->head.effective_connection_type =
           estimator->GetEffectiveConnectionType();
     }
   }
 
   const ServiceWorkerResponseInfo* service_worker_info =
       ServiceWorkerResponseInfo::ForRequest(request);
@@ skipping 632 matching lines @@
     }
 
     UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX);
   } else if (request_->response_info().unused_since_prefetch) {
     TimeDelta total_time = base::TimeTicks::Now() - request_->creation_time();
     UMA_HISTOGRAM_TIMES("Net.Prefetch.TimeSpentOnPrefetchHit", total_time);
   }
 }
 
 }  // namespace content