Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2213653002: Revert of Add WebWidgetTestProxy. (Closed)

Created:
4 years, 4 months ago by lfg
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add WebWidgetTestProxy. (patchset #4 id:60001 of https://codereview.chromium.org/2174663005/ ) Reason for revert: Causing layouttests to fail on the site isolation bot. Original issue's description: > Add WebWidgetTestProxy. > > This patch adds a WebWidgetTestProxy interface that is instantiated when running > LayoutTests and wraps RenderWidget in order to execute test-specific code. > > BUG=583347 > > Committed: https://crrev.com/1a99de092f8ad1974bb62af1a3f6f4f842e6db76 > Cr-Commit-Position: refs/heads/master@{#409539} TBR=esprehn@chromium.org,dcheng@chromium.org,jochen@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583347 Committed: https://crrev.com/465051d95e77757139e07760cd9a8d4d5a770ba4 Cr-Commit-Position: refs/heads/master@{#409678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -276 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/web_test_interfaces.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/web_view_test_proxy.h View 7 chunks +22 lines, -5 lines 0 comments Download
M components/test_runner/web_view_test_proxy.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/test_runner/web_widget_test_client.h View 3 chunks +1 line, -8 lines 0 comments Download
M components/test_runner/web_widget_test_client.cc View 6 chunks +10 lines, -11 lines 0 comments Download
D components/test_runner/web_widget_test_proxy.h View 1 chunk +0 lines, -114 lines 0 comments Download
D components/test_runner/web_widget_test_proxy.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/public/test/layouttest_support.h View 3 chunks +2 lines, -11 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 3 chunks +3 lines, -26 lines 0 comments Download
M content/test/layouttest_support.cc View 6 chunks +0 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameWidget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
lfg
Created Revert of Add WebWidgetTestProxy.
4 years, 4 months ago (2016-08-04 00:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213653002/1
4 years, 4 months ago (2016-08-04 00:14:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 00:16:54 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 00:18:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465051d95e77757139e07760cd9a8d4d5a770ba4
Cr-Commit-Position: refs/heads/master@{#409678}

Powered by Google App Engine
This is Rietveld 408576698