Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 221363002: Revert of Don't handle NaturalScroll in Chrome but pass it to CMT instead (Closed)

Created:
6 years, 8 months ago by rlarocque
Modified:
6 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Don't handle NaturalScroll in Chrome but pass it to CMT instead (https://codereview.chromium.org/212603005/) Reason for revert: Has caused many compile failures. We think the trybots didn't catch it because they didn't build ash_unittests. Example: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/46547 ../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollEventOneshot_Test::TestBody()': ../../ash/sticky_keys/sticky_keys_unittest.cc:622:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled' ../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollDirectionChanged_Test::TestBody()': ../../ash/sticky_keys/sticky_keys_unittest.cc:674:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled' ../../ash/sticky_keys/sticky_keys_unittest.cc: In member function 'virtual void ash::StickyKeysTest_ScrollEventLocked_Test::TestBody()': ../../ash/sticky_keys/sticky_keys_unittest.cc:711:41:error: 'class ui::DeviceDataManager' has no member named 'set_natural_scroll_enabled' ninja: build stopped: subcommand failed. Original issue's description: > Don't handle NaturalScroll in Chrome but pass it to CMT instead > > In order to support mice via CMT (Project Cobra) we will have to do > the natural scroll handling in the CMT driver instead of Chrome. > > BUG=chromium:285663 > TEST=test with touchpads and traditional mice. Everything should work as before, > touchpad should have natural scroll applied, scroll wheels should not. > Test changing the natural scroll property and see if it's applied correctly. > Also test if touch mice have natural scroll applied. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260926 TBR=achuith@chromium.org,sky@chromium.org,sadrul@chromium.org,denniskempin@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:285663 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/fake_input_device_settings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/fake_input_device_settings.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings.cc View 5 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/event_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/events/x/device_data_manager.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/events/x/device_data_manager.cc View 4 chunks +24 lines, -9 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rlarocque
Created Revert of Don't handle NaturalScroll in Chrome but pass it to CMT instead
6 years, 8 months ago (2014-04-01 20:08:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/221363002/1
6 years, 8 months ago (2014-04-01 20:08:20 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 20:09:34 UTC) #3
Message was sent while issue was closed.
Change committed as 260932

Powered by Google App Engine
This is Rietveld 408576698