Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2213613002: Converted observatory flag-list element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -97 lines) Patch
M runtime/observatory/lib/elements.dart View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.dart View 1 1 chunk +136 lines, -23 lines 0 comments Download
D runtime/observatory/lib/src/elements/flag_list.html View 1 chunk +0 lines, -53 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
A + runtime/observatory/lib/src/mocks/objects/flag.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/mocks/repositories/flag.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/flag.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/flag.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/repositories/flag.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 5 chunks +5 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/flag-list/element_test.dart View 1 1 chunk +60 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/flag-list/element_test.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-03 23:46:29 UTC) #2
Cutch
LGTM with tests
4 years, 4 months ago (2016-08-04 01:17:29 UTC) #3
cbernaschina
4 years, 4 months ago (2016-08-04 02:46:55 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-04 02:53:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
60afd8bddd16d39d4b9256b3096ddd2b5621cf35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698