chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json - Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json

Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed lgtm nits Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_once.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json

diff --git a/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..7ee939ef456876476027f02091a4c226b7c4da0f

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/manifest.json

@@ -0,0 +1,29 @@

+ "name": "duplicate script injection",

+ "version": "0.0.1",

+ "manifest_version": 2,

+ "description": "Tests that content scripts assigned to two overlapping url matches are not injected twice. Note this can be extended to N matches",

+ "background": {},

+ "content_scripts": [

+ {

+ "matches": ["*://*.google.com/*"],

+ "js": ["should_run_once.js"],

+ "run_at": "document_end"

+ },

+ {

+ "matches": ["*://maps.google.com/*"],

+ "js": ["should_run_once.js", "should_run_twice.js"],

+ "run_at": "document_end"

+ },

+ {

+ "matches": ["*://maps.google.com/*"],

+ "js": ["should_run_twice.js"],

+ "run_at": "document_idle"

+ },

+ {

+ "matches": ["*://*.maps.google.com/*"],

+ "js": ["should_run_once.js"],

+ "run_at": "document_end"

+ }

+ ]