extensions/renderer/programmatic_script_injector.h - Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed patch 6 code review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/content_scripts/duplicate_script_injection/should_run_twice.js ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/script_injection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/programmatic_script_injector.h

diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h

index b408d58a34a1ed5ada9774e8e417facd925c9cd8..f0d50078742f905b95e32c3c8addd071ed656b9a 100644

--- a/extensions/renderer/programmatic_script_injector.h

+++ b/extensions/renderer/programmatic_script_injector.h

@@ -33,18 +33,24 @@ class ProgrammaticScriptInjector : public ScriptInjector {

bool ShouldExecuteInMainWorld() const override;

bool IsUserGesture() const override;

bool ExpectsResults() const override;

- bool ShouldInjectJs(UserScript::RunLocation run_location) const override;

- bool ShouldInjectCss(UserScript::RunLocation run_location) const override;

+ bool ShouldInjectJs(UserScript::RunLocation run_location,

+ const std::set<GURL>& injected_scripts) const override;

+ bool ShouldInjectCss(UserScript::RunLocation run_location,

+ const std::set<GURL>& injected_scripts) const override;

PermissionsData::AccessType CanExecuteOnFrame(

const InjectionHost* injection_host,

blink::WebLocalFrame* web_frame,

int tab_id) const override;

std::vector<blink::WebScriptSource> GetJsSources(

- UserScript::RunLocation run_location) const override;

+ UserScript::RunLocation run_location,

+ std::set<GURL>& injected_scripts) const override;

Devlin 2016/08/29 20:48:14 nit: chromium style (mostly) forbids non-const &s.

catmullings 2016/09/01 17:43:51 Done.

std::vector<blink::WebString> GetCssSources(

- UserScript::RunLocation run_location) const override;

+ UserScript::RunLocation run_location,

+ std::set<GURL>& injected_scripts) const override;

void GetRunInfo(ScriptsRunInfo* scripts_run_info,

- UserScript::RunLocation run_location) const override;

+ UserScript::RunLocation run_location,

+ bool js_injection_completed,

+ bool should_inject_css) const override;

void OnInjectionComplete(std::unique_ptr<base::Value> execution_result,

UserScript::RunLocation run_location,

content::RenderFrame* render_frame) override;