Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: extensions/renderer/programmatic_script_injector.cc

Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test added Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/programmatic_script_injector.cc
diff --git a/extensions/renderer/programmatic_script_injector.cc b/extensions/renderer/programmatic_script_injector.cc
index e52885eee742fe261107ff1040b6628d9e532a83..2975754ea184b93b2cc6546a83acecd03510d906 100644
--- a/extensions/renderer/programmatic_script_injector.cc
+++ b/extensions/renderer/programmatic_script_injector.cc
@@ -18,6 +18,7 @@
#include "extensions/renderer/injection_host.h"
#include "extensions/renderer/renderer_extension_registry.h"
#include "extensions/renderer/script_context.h"
+#include "extensions/renderer/scripts_run_info.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
@@ -59,12 +60,14 @@ bool ProgrammaticScriptInjector::ExpectsResults() const {
}
bool ProgrammaticScriptInjector::ShouldInjectJs(
- UserScript::RunLocation run_location) const {
+ UserScript::RunLocation run_location,
+ std::set<GURL> injected_scripts) const {
return GetRunLocation() == run_location && params_->is_javascript;
}
bool ProgrammaticScriptInjector::ShouldInjectCss(
- UserScript::RunLocation run_location) const {
+ UserScript::RunLocation run_location,
+ std::set<GURL> injected_scripts) const {
return GetRunLocation() == run_location && !params_->is_javascript;
}
@@ -94,7 +97,8 @@ PermissionsData::AccessType ProgrammaticScriptInjector::CanExecuteOnFrame(
}
std::vector<blink::WebScriptSource> ProgrammaticScriptInjector::GetJsSources(
- UserScript::RunLocation run_location) const {
+ UserScript::RunLocation run_location,
+ ScriptsRunInfo* scripts_run_info) const {
DCHECK_EQ(GetRunLocation(), run_location);
DCHECK(params_->is_javascript);
@@ -105,7 +109,8 @@ std::vector<blink::WebScriptSource> ProgrammaticScriptInjector::GetJsSources(
}
std::vector<std::string> ProgrammaticScriptInjector::GetCssSources(
- UserScript::RunLocation run_location) const {
+ UserScript::RunLocation run_location,
+ ScriptsRunInfo* scripts_run_info) const {
DCHECK_EQ(GetRunLocation(), run_location);
DCHECK(!params_->is_javascript);

Powered by Google App Engine
This is Rietveld 408576698