Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: extensions/renderer/user_script_injector.h

Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed lgtm nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/scripts_run_info.h ('k') | extensions/renderer/user_script_injector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_ 5 #ifndef EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_
6 #define EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_ 6 #define EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 23 matching lines...) Expand all
34 private: 34 private:
35 // UserScriptSet::Observer implementation. 35 // UserScriptSet::Observer implementation.
36 void OnUserScriptsUpdated(const std::set<HostID>& changed_hosts, 36 void OnUserScriptsUpdated(const std::set<HostID>& changed_hosts,
37 const UserScriptList& scripts) override; 37 const UserScriptList& scripts) override;
38 38
39 // ScriptInjector implementation. 39 // ScriptInjector implementation.
40 UserScript::InjectionType script_type() const override; 40 UserScript::InjectionType script_type() const override;
41 bool ShouldExecuteInMainWorld() const override; 41 bool ShouldExecuteInMainWorld() const override;
42 bool IsUserGesture() const override; 42 bool IsUserGesture() const override;
43 bool ExpectsResults() const override; 43 bool ExpectsResults() const override;
44 bool ShouldInjectJs(UserScript::RunLocation run_location) const override; 44 bool ShouldInjectJs(
45 bool ShouldInjectCss(UserScript::RunLocation run_location) const override; 45 UserScript::RunLocation run_location,
46 const std::set<std::string>& executing_scripts) const override;
47 bool ShouldInjectCss(
48 UserScript::RunLocation run_location,
49 const std::set<std::string>& injected_stylesheets) const override;
46 PermissionsData::AccessType CanExecuteOnFrame( 50 PermissionsData::AccessType CanExecuteOnFrame(
47 const InjectionHost* injection_host, 51 const InjectionHost* injection_host,
48 blink::WebLocalFrame* web_frame, 52 blink::WebLocalFrame* web_frame,
49 int tab_id) const override; 53 int tab_id) const override;
50 std::vector<blink::WebScriptSource> GetJsSources( 54 std::vector<blink::WebScriptSource> GetJsSources(
51 UserScript::RunLocation run_location) const override; 55 UserScript::RunLocation run_location,
56 std::set<std::string>* executing_scripts,
57 size_t* num_injected_js_scripts) const override;
52 std::vector<blink::WebString> GetCssSources( 58 std::vector<blink::WebString> GetCssSources(
53 UserScript::RunLocation run_location) const override; 59 UserScript::RunLocation run_location,
54 void GetRunInfo(ScriptsRunInfo* scripts_run_info, 60 std::set<std::string>* injected_stylesheets,
55 UserScript::RunLocation run_location) const override; 61 size_t* num_injected_stylesheets) const override;
56 void OnInjectionComplete(std::unique_ptr<base::Value> execution_result, 62 void OnInjectionComplete(std::unique_ptr<base::Value> execution_result,
57 UserScript::RunLocation run_location, 63 UserScript::RunLocation run_location,
58 content::RenderFrame* render_frame) override; 64 content::RenderFrame* render_frame) override;
59 void OnWillNotInject(InjectFailureReason reason, 65 void OnWillNotInject(InjectFailureReason reason,
60 content::RenderFrame* render_frame) override; 66 content::RenderFrame* render_frame) override;
61 67
62 // The associated user script. Owned by the UserScriptInjector that created 68 // The associated user script. Owned by the UserScriptInjector that created
63 // this object. 69 // this object.
64 const UserScript* script_; 70 const UserScript* script_;
65 71
(...skipping 16 matching lines...) Expand all
82 88
83 ScopedObserver<UserScriptSet, UserScriptSet::Observer> 89 ScopedObserver<UserScriptSet, UserScriptSet::Observer>
84 user_script_set_observer_; 90 user_script_set_observer_;
85 91
86 DISALLOW_COPY_AND_ASSIGN(UserScriptInjector); 92 DISALLOW_COPY_AND_ASSIGN(UserScriptInjector);
87 }; 93 };
88 94
89 } // namespace extensions 95 } // namespace extensions
90 96
91 #endif // EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_ 97 #endif // EXTENSIONS_RENDERER_USER_SCRIPT_INJECTOR_H_
OLDNEW
« no previous file with comments | « extensions/renderer/scripts_run_info.h ('k') | extensions/renderer/user_script_injector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698