Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: extensions/renderer/programmatic_script_injector.h

Issue 2213603002: Prevent duplicate content script injection defined in manifest.json (reland) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed patch 8 code review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_ 5 #ifndef EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_
6 #define EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_ 6 #define EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/values.h" 11 #include "base/values.h"
12 #include "extensions/renderer/script_injection.h" 12 #include "extensions/renderer/script_injection.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 struct ExtensionMsg_ExecuteCode_Params; 15 struct ExtensionMsg_ExecuteCode_Params;
16 16
17 namespace content { 17 namespace content {
18 class RenderFrame; 18 class RenderFrame;
19 } 19 }
20 20
21 namespace extensions { 21 namespace extensions {
22 struct ScriptsRunInfo;
22 23
23 // A ScriptInjector to handle tabs.executeScript(). 24 // A ScriptInjector to handle tabs.executeScript().
24 class ProgrammaticScriptInjector : public ScriptInjector { 25 class ProgrammaticScriptInjector : public ScriptInjector {
25 public: 26 public:
26 ProgrammaticScriptInjector(const ExtensionMsg_ExecuteCode_Params& params, 27 ProgrammaticScriptInjector(const ExtensionMsg_ExecuteCode_Params& params,
27 content::RenderFrame* render_frame); 28 content::RenderFrame* render_frame);
28 ~ProgrammaticScriptInjector() override; 29 ~ProgrammaticScriptInjector() override;
29 30
30 private: 31 private:
31 // ScriptInjector implementation. 32 // ScriptInjector implementation.
32 UserScript::InjectionType script_type() const override; 33 UserScript::InjectionType script_type() const override;
33 bool ShouldExecuteInMainWorld() const override; 34 bool ShouldExecuteInMainWorld() const override;
34 bool IsUserGesture() const override; 35 bool IsUserGesture() const override;
35 bool ExpectsResults() const override; 36 bool ExpectsResults() const override;
36 bool ShouldInjectJs(UserScript::RunLocation run_location) const override; 37 bool ShouldInjectJs(UserScript::RunLocation run_location,
37 bool ShouldInjectCss(UserScript::RunLocation run_location) const override; 38 std::set<std::string>* executing_scripts) const override;
39 bool ShouldInjectCss(
40 UserScript::RunLocation run_location,
41 std::set<std::string>* injected_stylesheets) const override;
38 PermissionsData::AccessType CanExecuteOnFrame( 42 PermissionsData::AccessType CanExecuteOnFrame(
39 const InjectionHost* injection_host, 43 const InjectionHost* injection_host,
40 blink::WebLocalFrame* web_frame, 44 blink::WebLocalFrame* web_frame,
41 int tab_id) const override; 45 int tab_id) const override;
42 std::vector<blink::WebScriptSource> GetJsSources( 46 std::vector<blink::WebScriptSource> GetJsSources(
43 UserScript::RunLocation run_location) const override; 47 UserScript::RunLocation run_location,
48 std::set<std::string>* executing_scripts,
49 size_t* num_injected_js_scripts) const override;
44 std::vector<blink::WebString> GetCssSources( 50 std::vector<blink::WebString> GetCssSources(
45 UserScript::RunLocation run_location) const override; 51 UserScript::RunLocation run_location,
46 void GetRunInfo(ScriptsRunInfo* scripts_run_info, 52 std::set<std::string>* injected_stylesheets,
47 UserScript::RunLocation run_location) const override; 53 size_t* num_injected_stylesheets) const override;
48 void OnInjectionComplete(std::unique_ptr<base::Value> execution_result, 54 void OnInjectionComplete(std::unique_ptr<base::Value> execution_result,
49 UserScript::RunLocation run_location, 55 UserScript::RunLocation run_location,
50 content::RenderFrame* render_frame) override; 56 content::RenderFrame* render_frame) override;
51 void OnWillNotInject(InjectFailureReason reason, 57 void OnWillNotInject(InjectFailureReason reason,
52 content::RenderFrame* render_frame) override; 58 content::RenderFrame* render_frame) override;
53 59
54 // Whether it is safe to include information about the URL in error messages. 60 // Whether it is safe to include information about the URL in error messages.
55 bool CanShowUrlInError() const; 61 bool CanShowUrlInError() const;
56 62
57 // Return the run location for this injector. 63 // Return the run location for this injector.
(...skipping 18 matching lines...) Expand all
76 82
77 // Whether or not this script injection has finished. 83 // Whether or not this script injection has finished.
78 bool finished_; 84 bool finished_;
79 85
80 DISALLOW_COPY_AND_ASSIGN(ProgrammaticScriptInjector); 86 DISALLOW_COPY_AND_ASSIGN(ProgrammaticScriptInjector);
81 }; 87 };
82 88
83 } // namespace extensions 89 } // namespace extensions
84 90
85 #endif // EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_ 91 #endif // EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698