third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp - Issue 2213593002: OOPIF support for 'plugin-types' Content Security Policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2213593002: OOPIF support for 'plugin-types' Content Security Policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@csp-reporting-ipcs

Patch Set: Accounting for lack of https://crrev.com/2190183002 (i.e. no CSP reports from remote frames). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

index c1f94c09311701bc38eeecb9fd0e6566d1cab5b1..f7c210bd331f98a0d5238fdde3d2c8085aac7207 100644

--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

@@ -575,9 +575,7 @@ bool HTMLPlugInElement::allowedToLoadObject(const KURL& url, const String& mimeT

return false;

}

- AtomicString declaredMimeType = document().isPluginDocument() && document().localOwner() ?

- document().localOwner()->fastGetAttribute(HTMLNames::typeAttr) :

- fastGetAttribute(HTMLNames::typeAttr);

+ AtomicString declaredMimeType = fastGetAttribute(HTMLNames::typeAttr);

if (!document().contentSecurityPolicy()->allowObjectFromSource(url)

|| !document().contentSecurityPolicy()->allowPluginTypeForDocument(document(), mimeType, declaredMimeType, url)) {

if (LayoutEmbeddedItem layoutItem = layoutEmbeddedItem()) {

« no previous file with comments | « third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | no next file » | no next file with comments »