Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2213563003: Fixes keyboard event related bugs in switch person window. (Closed)

Created:
4 years, 4 months ago by sammiequon
Modified:
4 years, 4 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes keyboard event related bugs in switch person window. BUG=633058, 633868 Committed: https://crrev.com/442e7d64266217feb0d6299a8d31773d73775ecf Cr-Commit-Position: refs/heads/master@{#410147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ui/login/account_picker/user_pod_row.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sammiequon
jdufault@, xiyuan@ - Please take a look.
4 years, 4 months ago (2016-08-04 18:32:58 UTC) #3
jdufault
On 2016/08/04 18:32:58, sammiequon wrote: > jdufault@, xiyuan@ - Please take a look. lgtm, assuming ...
4 years, 4 months ago (2016-08-04 19:25:57 UTC) #4
xiyuan
lgtm
4 years, 4 months ago (2016-08-05 17:23:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213563003/1
4 years, 4 months ago (2016-08-05 19:04:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:41:11 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:43:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/442e7d64266217feb0d6299a8d31773d73775ecf
Cr-Commit-Position: refs/heads/master@{#410147}

Powered by Google App Engine
This is Rietveld 408576698