extensions/common/permissions/settings_override_permission.h - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/settings_override_permission.h

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/settings_override_permission.h

diff --git a/extensions/common/permissions/settings_override_permission.h b/extensions/common/permissions/settings_override_permission.h

index 48d3d71a74070886aa574f327be5a98728e96f6f..206595382fac868936cff44bd7c65b12a4fe1a51 100644

--- a/extensions/common/permissions/settings_override_permission.h

+++ b/extensions/common/permissions/settings_override_permission.h

@@ -25,7 +25,10 @@ class SettingsOverrideAPIPermission : public APIPermission {

virtual bool Check(const APIPermission::CheckParam* param) const OVERRIDE;

virtual bool Contains(const APIPermission* rhs) const OVERRIDE;

virtual bool Equal(const APIPermission* rhs) const OVERRIDE;

- virtual bool FromValue(const base::Value* value, std::string* error) OVERRIDE;

+ virtual bool FromValue(

+ const base::Value* value,

+ std::string* error,

+ std::vector<std::string>* unhandled_permissions) OVERRIDE;

virtual scoped_ptr<base::Value> ToValue() const OVERRIDE;

virtual APIPermission* Clone() const OVERRIDE;

virtual APIPermission* Diff(const APIPermission* rhs) const OVERRIDE;