chrome/browser/extensions/api/permissions/permissions_api_helpers.cc - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | chrome/common/extensions/permissions/media_galleries_permission_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

index 0caa191b250e822c611cb4a4b5f6d6e512f44934..19aa3e146832ca23d1578021be9fcb8825c1d32c 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc

@@ -108,7 +108,7 @@ scoped_refptr<PermissionSet> UnpackPermissionSet(

}

CHECK(permission);

- if (!permission->FromValue(permission_json.get(), NULL)) {

+ if (!permission->FromValue(permission_json.get(), NULL, NULL)) {

*error = ErrorUtils::FormatErrorMessage(kInvalidParameter, *it);

return NULL;

}