Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 221353002: telemetry: de-flake RenderingStatsUnitTest. (Closed)

Created:
6 years, 8 months ago by ernstm
Modified:
6 years, 8 months ago
Reviewers:
rlarocque, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

telemetry: de-flake RenderingStatsUnitTest. Advance timer before closing marker slices to make sure that marker extends beyond last event. R=tonyg@chromium.org,rlarocque@chromium.org BUG=358775 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/perf/metrics/rendering_stats_unittest.py View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ernstm
PTAL
6 years, 8 months ago (2014-04-01 20:00:09 UTC) #1
rlarocque
On 2014/04/01 20:00:09, ernstm wrote: > PTAL I don't understand this code so I'm not ...
6 years, 8 months ago (2014-04-01 20:12:42 UTC) #2
tonyg
lgtm I also wonder if we need some assertAlmostEquals instead of assertEqauls. But that shouldn't ...
6 years, 8 months ago (2014-04-01 20:26:27 UTC) #3
ernstm
On 2014/04/01 20:26:27, tonyg wrote: > lgtm > > I also wonder if we need ...
6 years, 8 months ago (2014-04-01 20:32:10 UTC) #4
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 8 months ago (2014-04-01 20:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/221353002/1
6 years, 8 months ago (2014-04-01 20:38:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/221353002/1
6 years, 8 months ago (2014-04-01 22:50:23 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 01:54:43 UTC) #8
Message was sent while issue was closed.
Change committed as 261034

Powered by Google App Engine
This is Rietveld 408576698