Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4827)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.h
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h
index fbcb7742a64986bd2b3d0f3aa8aa09f3fe2ff5f4..e1df56f87b548eaa1c2345ddc194c671208b934d 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.h
+++ b/content/browser/renderer_host/render_widget_host_view_mac.h
@@ -295,8 +295,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
void SelectionChanged(const base::string16& text,
size_t offset,
const gfx::Range& range) override;
- void SelectionBoundsChanged(
- const ViewHostMsg_SelectionBounds_Params& params) override;
void CopyFromCompositingSurface(const gfx::Rect& src_subrect,
const gfx::Size& dst_size,
const ReadbackRequestCallback& callback,
@@ -470,6 +468,10 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
// Exposed for testing.
cc::SurfaceId SurfaceIdForTesting() const override;
+ // This helper method will return the active widget from TextInputManager if
+ // it exists. Otherwise, it will return |render_widget_host_|.
+ RenderWidgetHostImpl* GetActiveWidget();
+
// Helper method to obtain ui::TextInputType for the active widget from the
// TextInputManager.
ui::TextInputType GetTextInputType();
@@ -538,12 +540,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac
gfx::Range composition_range_;
std::vector<gfx::Rect> composition_bounds_;
- // The current caret bounds.
- gfx::Rect caret_rect_;
-
- // The current first selection bounds.
- gfx::Rect first_selection_rect_;
-
// Factory used to safely scope delayed calls to ShutdownHost().
base::WeakPtrFactory<RenderWidgetHostViewMac> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698