content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a crash Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | content/browser/renderer_host/text_input_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 5d56ec10e8005ee90c648ba4baa2129583176a8c..f9cd7d0cda892b0f98d7e56d63474f226217f0f4 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -839,11 +839,6 @@ void RenderWidgetHostViewAndroid::SelectionChanged(const base::string16& text,

content_view_core_->OnSelectionChanged(utf8_selection);

}

-void RenderWidgetHostViewAndroid::SelectionBoundsChanged(

- const ViewHostMsg_SelectionBounds_Params& params) {

- NOTREACHED() << "Selection bounds should be routed through the compositor.";

void RenderWidgetHostViewAndroid::SetBackgroundColor(SkColor color) {

RenderWidgetHostViewBase::SetBackgroundColor(color);

host_->SetBackgroundOpaque(GetBackgroundOpaque());