content/browser/renderer_host/render_widget_host_view_mac.h - Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.h

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h

index a7da0a994d2ff48872927f6b75db0a2881392b32..b69e0ebc981056f47ab608a4deb714909f54893d 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.h

+++ b/content/browser/renderer_host/render_widget_host_view_mac.h

@@ -288,8 +288,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

int error_code) override;

void Destroy() override;

void SetTooltipText(const base::string16& tooltip_text) override;

- void SelectionBoundsChanged(

- const ViewHostMsg_SelectionBounds_Params& params) override;

void CopyFromCompositingSurface(const gfx::Rect& src_subrect,

const gfx::Size& dst_size,

const ReadbackRequestCallback& callback,

@@ -542,12 +540,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

gfx::Range composition_range_;

std::vector<gfx::Rect> composition_bounds_;

- // The current caret bounds.

- gfx::Rect caret_rect_;

- // The current first selection bounds.

- gfx::Rect first_selection_rect_;

// Factory used to safely scope delayed calls to ShutdownHost().

base::WeakPtrFactory<RenderWidgetHostViewMac> weak_factory_;