Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing some #ifdefs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 449fcd92927cd837b031cb869bfe84b213e09e2b..ef5352855cc373bcaa9a04b49f8ee14147f1ee82 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -64,6 +64,18 @@ RenderWidgetHostViewBase::~RenderWidgetHostViewBase() {
text_input_manager_->Unregister(this);
}
+RenderWidgetHostImpl* RenderWidgetHostViewBase::GetFocusedWidget() const {
+ RenderWidgetHostImpl* host =
+ RenderWidgetHostImpl::From(GetRenderWidgetHost());
+ return host && host->delegate()
+ ? host->delegate()->GetFocusedRenderWidgetHost(host)
+ : nullptr;
+}
+
+RenderWidgetHost* RenderWidgetHostViewBase::GetRenderWidgetHost() const {
+ return nullptr;
+}
+
void RenderWidgetHostViewBase::NotifyObserversAboutShutdown() {
// Note: RenderWidgetHostInputEventRouter is an observer, and uses the
// following notification to remove this view from its surface owners map.
@@ -107,8 +119,12 @@ float RenderWidgetHostViewBase::GetTopControlsHeight() const {
void RenderWidgetHostViewBase::SelectionBoundsChanged(
const ViewHostMsg_SelectionBounds_Params& params) {
+#if !defined(OS_ANDROID)
if (GetTextInputManager())
GetTextInputManager()->SelectionBoundsChanged(this, params);
+#else
+ NOTREACHED() << "Selection bounds should be routed through the compositor.";
+#endif
}
void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,

Powered by Google App Engine
This is Rietveld 408576698