Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2213503002: Tracking SelectionBounds for all RenderWidgets on the Browser Side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_base.h" 5 #include "content/browser/renderer_host/render_widget_host_view_base.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "content/browser/accessibility/browser_accessibility_manager.h" 9 #include "content/browser/accessibility/browser_accessibility_manager.h"
10 #include "content/browser/gpu/gpu_data_manager_impl.h" 10 #include "content/browser/gpu/gpu_data_manager_impl.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 bool RenderWidgetHostViewBase::DoTopControlsShrinkBlinkSize() const { 113 bool RenderWidgetHostViewBase::DoTopControlsShrinkBlinkSize() const {
114 return false; 114 return false;
115 } 115 }
116 116
117 float RenderWidgetHostViewBase::GetTopControlsHeight() const { 117 float RenderWidgetHostViewBase::GetTopControlsHeight() const {
118 return 0.f; 118 return 0.f;
119 } 119 }
120 120
121 void RenderWidgetHostViewBase::SelectionBoundsChanged( 121 void RenderWidgetHostViewBase::SelectionBoundsChanged(
122 const ViewHostMsg_SelectionBounds_Params& params) { 122 const ViewHostMsg_SelectionBounds_Params& params) {
123 #if !defined(OS_ANDROID)
123 if (GetTextInputManager()) 124 if (GetTextInputManager())
124 GetTextInputManager()->SelectionBoundsChanged(this, params); 125 GetTextInputManager()->SelectionBoundsChanged(this, params);
126 #else
127 NOTREACHED() << "Selection bounds should be routed through the compositor.";
128 #endif
125 } 129 }
126 130
127 float RenderWidgetHostViewBase::GetBottomControlsHeight() const { 131 float RenderWidgetHostViewBase::GetBottomControlsHeight() const {
128 return 0.f; 132 return 0.f;
129 } 133 }
130 134
131 void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text, 135 void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,
132 size_t offset, 136 size_t offset,
133 const gfx::Range& range) { 137 const gfx::Range& range) {
134 // TODO(ekaramad): Use TextInputManager code paths for IME on other platforms. 138 // TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 514
511 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const { 515 bool RenderWidgetHostViewBase::IsChildFrameForTesting() const {
512 return false; 516 return false;
513 } 517 }
514 518
515 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const { 519 cc::SurfaceId RenderWidgetHostViewBase::SurfaceIdForTesting() const {
516 return cc::SurfaceId(); 520 return cc::SurfaceId();
517 } 521 }
518 522
519 } // namespace content 523 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698