Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2213473003: MD Settings: Remove some unhelpful properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@JustSubpageHidePatch
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 }, 48 },
49 }, 49 },
50 }, 50 },
51 51
52 /** @private {?settings.AboutPageBrowserProxy} */ 52 /** @private {?settings.AboutPageBrowserProxy} */
53 aboutBrowserProxy_: null, 53 aboutBrowserProxy_: null,
54 54
55 /** @private {?settings.LifetimeBrowserProxy} */ 55 /** @private {?settings.LifetimeBrowserProxy} */
56 lifetimeBrowserProxy_: null, 56 lifetimeBrowserProxy_: null,
57 57
58 /**
59 * @type {string} Selector to get the sections.
60 * TODO(michaelpg): replace duplicate docs with @override once b/24294625
61 * is fixed.
62 */
63 sectionSelector: 'settings-section',
64
65 /** @override */ 58 /** @override */
66 attached: function() { 59 attached: function() {
67 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance(); 60 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
68 this.aboutBrowserProxy_.pageReady(); 61 this.aboutBrowserProxy_.pageReady();
69 62
70 this.lifetimeBrowserProxy_ = 63 this.lifetimeBrowserProxy_ =
71 settings.LifetimeBrowserProxyImpl.getInstance(); 64 settings.LifetimeBrowserProxyImpl.getInstance();
72 65
73 <if expr="chromeos"> 66 <if expr="chromeos">
74 this.addEventListener('target-channel-changed', function(e) { 67 this.addEventListener('target-channel-changed', function(e) {
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 }, 284 },
292 </if> 285 </if>
293 286
294 <if expr="_google_chrome"> 287 <if expr="_google_chrome">
295 /** @private */ 288 /** @private */
296 onReportIssueTap_: function() { 289 onReportIssueTap_: function() {
297 this.aboutBrowserProxy_.openFeedbackDialog(); 290 this.aboutBrowserProxy_.openFeedbackDialog();
298 }, 291 },
299 </if> 292 </if>
300 }); 293 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698