Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2213423002:
Measure SVGViewElement Constructor (Closed)
|
Created:
4 years, 4 months ago by Shanmuga Pandi Modified:
4 years, 4 months ago CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMeasure SVGViewElement Constructor
There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect.
But this usage is already pointing to Zero
Measuring SVGViewElement constructor will give more usage details of this.
BUG=633908
Committed: https://crrev.com/64e154a121889ecffbf0edaed11708b18257aa50
Cr-Commit-Position: refs/heads/master@{#410709}
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased #
Messages
Total messages: 33 (21 generated)
Description was changed from ========== Measure SVGViewElement usage BUG=633908 ========== to ========== Measure SVGViewElement Constructor There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect. But this usage is already pointing to Zero Measuring SVGViewElement constructor will give more usage details of this. BUG=633908 ==========
shanmuga.m@samsung.com changed reviewers: + foolip@chromium.org, fs@opera.com, pdr@chromium.org, rob.buis@samsung.com
shanmuga.m@samsung.com changed reviewers: + isherman@chromium.org
PTAL!!
lgtm
The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by shanmuga.m@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shanmuga.m@samsung.com changed reviewers: + mkwst@chromium.org
+mkwst for histograms OWNERS
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mkwst@ , isherman@ Please review tools/metrics/histograms/histograms.xml
histograms.xml lgtm
The CQ bit was checked by isherman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com Link to the patchset: https://codereview.chromium.org/2213423002/#ps20001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for tools/metrics/histograms/histograms.xml: While running git apply --index -3 -p1; error: patch failed: tools/metrics/histograms/histograms.xml:77991 Falling back to three-way merge... Applied patch to 'tools/metrics/histograms/histograms.xml' with conflicts. U tools/metrics/histograms/histograms.xml Patch: tools/metrics/histograms/histograms.xml Index: tools/metrics/histograms/histograms.xml diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 29bd28575de8e128826d0575f666c29494cc543e..1b7ab7ad302595dee6e69c0f17359fe62beca7c3 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -77991,6 +77991,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. <int value="1483" label="StarInTimingAllowOrigin"/> <int value="1484" label="SVGSMILAdditiveAnimation"/> <int value="1485" label="SendBeaconWithNonSimpleContentType"/> + <int value="1486" label="SVGViewElement"/> </enum> <enum name="FetchRequestMode" type="int">
The CQ bit was checked by shanmuga.m@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2213423002/#ps40001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by shanmuga.m@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Measure SVGViewElement Constructor There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect. But this usage is already pointing to Zero Measuring SVGViewElement constructor will give more usage details of this. BUG=633908 ========== to ========== Measure SVGViewElement Constructor There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect. But this usage is already pointing to Zero Measuring SVGViewElement constructor will give more usage details of this. BUG=633908 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Measure SVGViewElement Constructor There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect. But this usage is already pointing to Zero Measuring SVGViewElement constructor will give more usage details of this. BUG=633908 ========== to ========== Measure SVGViewElement Constructor There is already usecounter (SVGSVGElementFragmentSVGViewElement), when SVGViewElement having some effect. But this usage is already pointing to Zero Measuring SVGViewElement constructor will give more usage details of this. BUG=633908 Committed: https://crrev.com/64e154a121889ecffbf0edaed11708b18257aa50 Cr-Commit-Position: refs/heads/master@{#410709} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/64e154a121889ecffbf0edaed11708b18257aa50 Cr-Commit-Position: refs/heads/master@{#410709} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
