Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp

Issue 2213393002: Defer computing localeForHan until needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp b/third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
index 5ae67b7cc5ae5b0103f2bab17a1e5c952d6cbc97..4dd49562edd28f30f1d677543ce36a34126585e4 100644
--- a/third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
+++ b/third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
@@ -8,11 +8,25 @@
namespace blink {
+static String& current()
drott 2016/08/08 15:16:37 Could you give this a more descriptive name?
kojii 2016/08/08 15:33:54 Changed to currentAcceptLanguages().
+{
+ DEFINE_STATIC_LOCAL(String, s_current, ());
+ return s_current;
+}
+
void AcceptLanguagesResolver::acceptLanguagesChanged(
const String& acceptLanguages)
{
- LayoutLocale::setLocaleForHan(
- localeForHanFromAcceptLanguages(acceptLanguages));
+ if (current() == acceptLanguages)
+ return;
+
+ current() = acceptLanguages;
+ LayoutLocale::InvalidateLocaleForHan();
+}
+
+const LayoutLocale* AcceptLanguagesResolver::localeForHan()
+{
+ return localeForHanFromAcceptLanguages(current());
}
const LayoutLocale* AcceptLanguagesResolver::localeForHanFromAcceptLanguages(

Powered by Google App Engine
This is Rietveld 408576698