Defer computing localeForHan until needed

Defer computing localeForHan until needed

This patch defers computing LayoutLocale::localeForHan() until it is
needed.

On Mac, localeForHan() is not used. On other platforms, it is used only
when fallback for Han characters is needed.

BUG=586517, 633943
Committed: https://crrev.com/f7f744c29306b76d03bd3a9146562bb1ca2f830f
Cr-Commit-Position: refs/heads/master@{#410424}

[kojii, 2016-08-05 08:00:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 08:00:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 08:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:17:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kojii, 2016-08-05 08:32:44]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 08:32:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 08:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:45:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-08-08 06:51:16]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-08 06:55:17]

Description was changed from

==========
locale-defer

BUG=
==========

to

==========
Defer computing localeForHan until needed

This patch defers computing LayoutLocale::localeForHan() until it is
needed.

On Mac, localeForHan() is not used. On other platforms, it is used only
when fallback for Han characters is needed.

BUG=586517, 633943
==========

[kojii, 2016-08-08 06:57:50]

kojii@chromium.org changed reviewers:
+ drott@chromium.org

[kojii, 2016-08-08 06:57:50]

PTAL.

[commit-bot: I haz the power, 2016-08-08 08:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 08:01:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[drott, 2016-08-08 12:36:52]

I am assuming this is trying to address mainly 633943? Did this really reduce
memory as issue 633943 is reporting? Could it be that there is a leak of
LayoutLocale* objects or returned char*'s? Do we need to keep the
getLocaleMap(), or could we create LayoutLocale objects on the fly and return a
RefPtr from LayoutLocale::get?

[kojii, 2016-08-08 14:11:02]

On 2016/08/08 at 12:36:52, drott wrote:
> I am assuming this is trying to address mainly 633943? Did this really reduce
memory as issue 633943 is reporting? Could it be that there is a leak of
LayoutLocale* objects or returned char*'s? Do we need to keep the
getLocaleMap(), or could we create LayoutLocale objects on the fly and return a
RefPtr from LayoutLocale::get?

Well, yes and no. Certainly this was I inspired by 633943. But this also saves
some CPU cycles and memory on win/Linux/Android when user has nothing to do with
Han, so nice to take regardless this addresses 633943 or not.

I reviewed the code multiple times but I can't see any possible leaks. Also leak
is not observed in other platforms.

My best guess is that the test has ~16kb increase before, and this time is ~16kb
too, so whenever additional memory fills the allocated page, it requests another
16kb.

In addition to this memory, the CL adds support for 14 additional locals (plus
14 aliases), so it's not surprising that we now need another page. I'm thinking
to see the graph by landing this, and if it doesn't recover, I'll ask how
reasonable my guess is in the bug.

Does this look reasonable?

[kojii, 2016-08-08 15:01:18]

Forgot to add that there's one more possibility I'd like to try in a separate
CL, but having each separated will help to see how graph goes.

[drott, 2016-08-08 15:16:37]

I reviewed it now, LGTM with nits.

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/LayoutLocale.h (right):

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/LayoutLocale.h:45: static void
InvalidateLocaleForHan() { s_defaultForHanComputed = false; }
lowercase first letter => invalidateLocaleForHan()

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
(right):

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp:11: static
String& current()
Could you give this a more descriptive name?

[kojii, 2016-08-08 15:31:01]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 15:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-08-08 15:33:54]

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/LayoutLocale.h (right):

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/LayoutLocale.h:45: static void
InvalidateLocaleForHan() { s_defaultForHanComputed = false; }
On 2016/08/08 at 15:16:37, drott wrote:
> lowercase first letter => invalidateLocaleForHan()

Thanks for catching, confused with Chromium style...

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp
(right):

https://codereview.chromium.org/2213393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/AcceptLanguagesResolver.cpp:11: static
String& current()
On 2016/08/08 at 15:16:37, drott wrote:
> Could you give this a more descriptive name?

Changed to currentAcceptLanguages().

[commit-bot: I haz the power, 2016-08-08 17:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 17:36:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-08-08 17:42:11]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-08-08 17:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2213393002/#ps60001
(title: "drott review")

[commit-bot: I haz the power, 2016-08-08 17:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:17:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-08 20:21:18]

Description was changed from

==========
Defer computing localeForHan until needed

This patch defers computing LayoutLocale::localeForHan() until it is
needed.

On Mac, localeForHan() is not used. On other platforms, it is used only
when fallback for Han characters is needed.

BUG=586517, 633943
==========

to

==========
Defer computing localeForHan until needed

This patch defers computing LayoutLocale::localeForHan() until it is
needed.

On Mac, localeForHan() is not used. On other platforms, it is used only
when fallback for Han characters is needed.

BUG=586517, 633943

Committed: https://crrev.com/f7f744c29306b76d03bd3a9146562bb1ca2f830f
Cr-Commit-Position: refs/heads/master@{#410424}
==========

[commit-bot: I haz the power, 2016-08-08 20:21:19]

Patchset 4 (id:??) landed as
https://crrev.com/f7f744c29306b76d03bd3a9146562bb1ca2f830f
Cr-Commit-Position: refs/heads/master@{#410424}