Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 221333002: Fix an issue that webkit-transform might impact fullscreen video (Closed)

Created:
6 years, 8 months ago by qinmin
Modified:
6 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix an issue that webkit-transform might impact fullscreen video Fullscreen video should ignore all css transforms. BUG=356282 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170810

Patch Set 1 : #

Total comments: 4

Patch Set 2 : use reftest instead #

Patch Set 3 : add layout test result for virtual/android due to the special flag we added earlier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
A LayoutTests/fullscreen/video-webkit-transform.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/video-webkit-transform-expected.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/virtual/android/fullscreen/video-webkit-transform-expected.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
qinmin
PTAL
6 years, 8 months ago (2014-04-01 19:27:16 UTC) #1
qinmin
ping. acolwell@, would you please take a look at this change? According to scherkus@ on ...
6 years, 8 months ago (2014-04-03 17:24:09 UTC) #2
acolwell GONE FROM CHROMIUM
It seems like we should be able to make this a ref test instead of ...
6 years, 8 months ago (2014-04-03 17:44:33 UTC) #3
qinmin
Also changed pixel test to ref test https://codereview.chromium.org/221333002/diff/20001/LayoutTests/fullscreen/video-webkit-transform.html File LayoutTests/fullscreen/video-webkit-transform.html (right): https://codereview.chromium.org/221333002/diff/20001/LayoutTests/fullscreen/video-webkit-transform.html#newcode12 LayoutTests/fullscreen/video-webkit-transform.html:12: waitForEvent(document, 'webkitfullscreenchange', ...
6 years, 8 months ago (2014-04-03 18:35:35 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-03 20:26:36 UTC) #5
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-03 21:02:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/221333002/40001
6 years, 8 months ago (2014-04-03 21:02:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 21:36:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-03 21:36:46 UTC) #9
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-03 22:10:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/221333002/40001
6 years, 8 months ago (2014-04-03 22:11:02 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 22:15:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-03 22:15:28 UTC) #13
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-03 22:53:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/221333002/60001
6 years, 8 months ago (2014-04-03 22:53:54 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 23:19:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-03 23:19:10 UTC) #17
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 8 months ago (2014-04-03 23:41:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/221333002/60001
6 years, 8 months ago (2014-04-03 23:41:45 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 00:27:54 UTC) #20
Message was sent while issue was closed.
Change committed as 170810

Powered by Google App Engine
This is Rietveld 408576698