Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2213313002: Not migrate old domain scoped cookie content settings (Closed)

Created:
4 years, 4 months ago by lshang
Modified:
4 years, 4 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Not migrate old domain scoped cookie content settings Change back to not migrate cookie settings so that we don't make too much inconvenience for the user. BUG=633680 Committed: https://crrev.com/a068a972414767b211e60016da07676f6f7ed4fc Cr-Commit-Position: refs/heads/master@{#410041}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -52 lines) Patch
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 10 chunks +102 lines, -51 lines 1 comment Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
lshang
PTAL thanks!
4 years, 4 months ago (2016-08-05 03:03:04 UTC) #10
msramek
LGTM! Thanks, Liu! Sorry for pushing back on this now, I should perhaps have been ...
4 years, 4 months ago (2016-08-05 09:04:03 UTC) #11
msramek
So, I'll land this on your behalf now to minimize users' exposure to the current ...
4 years, 4 months ago (2016-08-05 12:33:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213313002/20001
4 years, 4 months ago (2016-08-05 12:33:39 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-05 12:37:31 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a068a972414767b211e60016da07676f6f7ed4fc Cr-Commit-Position: refs/heads/master@{#410041}
4 years, 4 months ago (2016-08-05 12:39:25 UTC) #18
lshang
4 years, 4 months ago (2016-08-06 04:01:11 UTC) #19
Message was sent while issue was closed.
On 2016/08/05 12:33:15, msramek wrote:
> So, I'll land this on your behalf now to minimize users' exposure to the
current
> cookies migration.

Thanks for land it for me. I was thinking that if you're ok with this patch then
feel free to land it immediately, but forgot to leave a note then:P

Powered by Google App Engine
This is Rietveld 408576698