Not migrate old domain scoped cookie content settings

Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680
Committed: https://crrev.com/a068a972414767b211e60016da07676f6f7ed4fc
Cr-Commit-Position: refs/heads/master@{#410041}

[lshang, 2016-08-05 00:45:42]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:46:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-08-05 00:52:28]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:52:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-08-05 00:56:19]

Description was changed from

==========
Not migrate old domain scoped cookie content settings


not migrate cookies

BUG=
==========

to

==========
Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680
==========

[lshang, 2016-08-05 02:56:40]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-05 03:02:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 03:02:40]

Dry run: This issue passed the CQ dry run.

[lshang, 2016-08-05 03:03:04]

lshang@chromium.org changed reviewers:
+ msramek@chromium.org

[lshang, 2016-08-05 03:03:04]

PTAL thanks!

[msramek, 2016-08-05 09:04:03]

LGTM! Thanks, Liu!

Sorry for pushing back on this now, I should perhaps have been more vocal
earlier. But well, we knew that user complaints may come...

I left one optional nit; since it's Friday evening for you and since I think
this should land ASAP, feel free to just land the CL immediately, or I'll take
the liberty to do it for you :)

https://codereview.chromium.org/2213313002/diff/20001/chrome/browser/content_...
File chrome/browser/content_settings/host_content_settings_map_unittest.cc
(right):

https://codereview.chromium.org/2213313002/diff/20001/chrome/browser/content_...
chrome/browser/content_settings/host_content_settings_map_unittest.cc:1463: //
Settings also apply to subdomains.
nit: This comment seems misplaced, since it also applies to |http_host_narrower|
on lines 1451..1454. Maybe move that one EXPECT_EQ down here?

[msramek, 2016-08-05 12:33:15]

So, I'll land this on your behalf now to minimize users' exposure to the current
cookies migration.

[msramek, 2016-08-05 12:33:21]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-08-05 12:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:37:30]

Description was changed from

==========
Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680
==========

to

==========
Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680
==========

[commit-bot: I haz the power, 2016-08-05 12:37:31]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-05 12:39:24]

Description was changed from

==========
Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680
==========

to

==========
Not migrate old domain scoped cookie content settings

Change back to not migrate cookie settings so that we don't make too much
inconvenience for the user.

BUG=633680

Committed: https://crrev.com/a068a972414767b211e60016da07676f6f7ed4fc
Cr-Commit-Position: refs/heads/master@{#410041}
==========

[commit-bot: I haz the power, 2016-08-05 12:39:25]

Patchset 1 (id:??) landed as
https://crrev.com/a068a972414767b211e60016da07676f6f7ed4fc
Cr-Commit-Position: refs/heads/master@{#410041}

[lshang, 2016-08-06 04:01:11]

On 2016/08/05 12:33:15, msramek wrote:
> So, I'll land this on your behalf now to minimize users' exposure to the
current
> cookies migration.

Thanks for land it for me. I was thinking that if you're ok with this patch then
feel free to land it immediately, but forgot to leave a note then:P