ozone: Consolidate primary plane format.

ozone: Consolidate primary plane format.

Prior to this change the BufferFormat used by the primary plane
was defined in multiple places.

This CL consolidates the buffer format in DisplayMode::PrimaryFormat.

In addition RGB/BGR formats have been added where needed so that
it is now possible to switch the primary plane format from BGR to
RGB changing only the return value of DisplayMode::PrimaryFormat.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0a50f6440e5b2283ed1df4deaebb51cfa6bbe54f
Cr-Commit-Position: refs/heads/master@{#411126}

[Daniele Castagna, 2016-08-04 22:38:20]

Description was changed from

==========
ozone: Consolidate primary plane format.

Prior to this change the BufferFormat used by the primary plane
was defined in multiple places.

This CL consolidates the buffer format in DisplayMode::PrimaryFormat.

In addition RGB/BGR formats have been added where needed so that
it is now possible to switch the primary plane format from BGR to
RGB changing only the return value of DisplayMode::PrimaryFormat.

BUG=b/29430506
==========

to

==========
ozone: Consolidate primary plane format.

Prior to this change the BufferFormat used by the primary plane
was defined in multiple places.

This CL consolidates the buffer format in DisplayMode::PrimaryFormat.

In addition RGB/BGR formats have been added where needed so that
it is now possible to switch the primary plane format from BGR to
RGB changing only the return value of DisplayMode::PrimaryFormat.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Daniele Castagna, 2016-08-04 22:38:33]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:39:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-04 22:40:15]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org, hoegsberg@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:17:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-08-05 00:09:36]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:45:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-08-05 00:49:30]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 00:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 01:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 01:41:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dnicoara, 2016-08-05 13:59:44]

dnicoara@chromium.org changed reviewers:
+ oshima@chromium.org, spang@chromium.org

[dnicoara, 2016-08-05 13:59:45]

+ oshima@ for ui/display
+ spang@ for rest of ui/ozone

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/DEPS
File ui/display/types/DEPS (left):

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/DEPS#o...
ui/display/types/DEPS:4: "+ui/gfx/geometry",
Could would just add the ui/gfx:memory_buffer dependency? ui/gfx is quite large
and this doesn't need all those dependencies.

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/displa...
File ui/display/types/display_mode.h (right):

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/displa...
ui/display/types/display_mode.h:34: static gfx::BufferFormat PrimaryFormat();
This would better fit onto the DisplaySnapshot since this would be a display
related configuration.

[Ken Russell (switch to Gerrit), 2016-08-05 18:24:01]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-05 18:24:02]

Just to confirm -- have you seen the assertion failures this CL is provoking in
the WebGL 2.0 conformance tests on Mac OS? It seems to be breaking the Core
Profile code path there.

WebglConformance_deqp_data_gles3_shaders_functions
(gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest)
... [2672:1299:0804/184854:FATAL:command_buffer_proxy_impl.cc(479)] Check
failed: gpu::IsImageFormatCompatibleWithGpuMemoryBufferFormat( internal_format,
gpu_memory_buffer->GetFormat()). 
0   Chromium Framework                  0x000000010d4f2423
_ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x000000010d513437
_ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x000000010b4dccef
_ZN3gpu22CommandBufferProxyImpl11CreateImageEP13_ClientBuffermmj + 751
3   Chromium Framework                  0x000000010f0628fd
_ZN3gpu5gles219GLES2Implementation25CreateImageCHROMIUMHelperEP13_ClientBufferiij
+ 269
4   Chromium Framework                  0x000000010f010a33
_ZN18display_compositor11BufferQueue14GetNextSurfaceEv + 435
5   Chromium Framework                  0x000000010f010805
_ZN18display_compositor11BufferQueue15BindFramebufferEv + 53
6   Chromium Framework                  0x000000010bb54249
_ZN7content44GpuSurfacelessBrowserCompositorOutputSurface15BindFramebufferEv +
105
7   Chromium Framework                  0x000000010e71b12b
_ZN2cc10GLRenderer30BindFramebufferToOutputSurfaceEPNS_14DirectRenderer12DrawingFrameE
+ 59
8   Chromium Framework                  0x000000010e7005f7
_ZN2cc14DirectRenderer13UseRenderPassEPNS0_12DrawingFrameEPKNS_10RenderPassE +
343
9   Chromium Framework                  0x000000010e6ffb9b
_ZN2cc14DirectRenderer14DrawRenderPassEPNS0_12DrawingFrameEPKNS_10RenderPassE +
91
10  Chromium Framework                  0x000000010e6ff3f2
_ZN2cc14DirectRenderer36DrawRenderPassAndExecuteCopyRequestsEPNS0_12DrawingFrameEPNS_10RenderPassE
+ 194
11  Chromium Framework                  0x000000010e6ff177
_ZN2cc14DirectRenderer9DrawFrameEPNSt3__16vectorINS1_10unique_ptrINS_10RenderPassENS1_14default_deleteIS4_EEEENS1_9allocatorIS7_EEEEfRKN3gfx10ColorSpaceERKNSC_4RectESI_
+ 1351
12  Chromium Framework                  0x000000010ef3b8c7
_ZN2cc7Display11DrawAndSwapEv + 1351
13  Chromium Framework                  0x000000010ef3dc36
_ZN2cc16DisplayScheduler11DrawAndSwapEv + 230
14  Chromium Framework                  0x000000010ef3ce74
_ZN2cc16DisplayScheduler20OnBeginFrameDeadlineEv + 52
15  Chromium Framework                  0x000000010d4f2a9b
_ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 187
16  Chromium Framework                  0x000000010d5273cc
_ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 572
17  Chromium Framework                  0x000000010d5276ec
_ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 44
18  Chromium Framework                  0x000000010d527cdd
_ZN4base11MessageLoop13DoDelayedWorkEPNS_9TimeTicksE + 317
19  Chromium Framework                  0x000000010d52b256 _ZN4</span><span
class="stdout">base24MessagePumpCFRunLoopBase7RunWorkEv + 86
</span><span class="stdout">20  Chromium Framework                 
0x000000010d514a2a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10
21  Chromium Framework                  0x000000010d52ab84
_ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 68
22  CoreFoundation                      0x00007fff874d0a01
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
23  CoreFoundation                      0x00007fff874c2b8d __CFRunLoopDoSources0
+ 269
24  CoreFoundation                      0x00007fff874c21bf __CFRunLoopRun + 927
25  CoreFoundation                      0x00007fff874c1bd8 CFRunLoopRunSpecific
+ 296
26  HIToolbox                           0x00007fff89c2c56f
RunCurrentEventLoopInMode + 235
27  HIToolbox                           0x00007fff89c2c2ea
ReceiveNextEventCommon + 431
28  HIToolbox                           0x00007fff89c2c12b
_BlockUntilNextEventMatchingListInModeWithFilter + 71
29  AppKit                              0x00007fff85ea38ab _DPSNextEvent + 978
30  AppKit                              0x00007fff85ea2e58 -[NSApplication
nextEventMatchingMask:untilDate:inMode:dequeue:] + 346
31  AppKit                              0x00007fff85e98af3 -[NSApplication run]
+ 594
32  Chromium Framework                  0x000000010d52bc87
_ZN4base24MessagePumpNSApplication5DoRunEPNS_11MessagePump8DelegateE + 359
33  Chromium Framework                  0x000000010d52b00f
_ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 127
34  Chromium Framework                  0x000000010d526f27
_ZN4base11MessageLoop10RunHandlerEv + 215
35  Chromium Framework                  0x000000010d554913
_ZN4base7RunLoop3RunEv + 51
36  Chromium Framework                  0x000000010cfaeba8
_ZN22ChromeBrowserMainParts18MainMessageLoopRunEPi + 280
37  Chromium Framework                  0x000000010b6cd974
_ZN7content15BrowserMainLoop23RunMainMessageLoopPartsEv + 52
38  Chromium Framework                  0x000000010b6d05ee
_ZN7content21BrowserMainRunnerImpl3RunEv + 174
39  Chromium Framework                  0x000000010b6c9b9d
_ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 173
40  Chromium Framework                  0x000000010cf5b912
_ZN7content21ContentMainRunnerImpl3RunEv + 802
41  Chromium Framework                  0x000000010cf5a8f6
_ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
42  Chromium Framework                  0x000000010b3251fa ChromeMain + 58
43  Chromium                            0x000000010b2bdd5a main + 522
44  Chromium                            0x000000010b2bdb44 start + 52
45  ???                                 0x00

[Ken Russell (switch to Gerrit), 2016-08-05 18:24:53]

Example failure:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu...

[Daniele Castagna, 2016-08-05 19:18:50]

On 2016/08/05 at 18:24:53, kbr wrote:
> Example failure:
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu...

Noticed that, looking into it.
I was incorrectly assuming we were using BufferQueue only with one internal
format, but apparently it can be either RGB or RGBA.

[Daniele Castagna, 2016-08-05 22:35:09]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 22:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 23:23:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:23:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-08-05 23:44:41]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-05 23:46:59]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-08-06 00:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:30:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-08-06 00:33:07]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[Daniele Castagna, 2016-08-06 00:33:10]

Patchset #5 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-08-06 00:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-06 01:19:21]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 01:19:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-06 01:19:42]

Patchset #5 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-08-06 02:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 02:25:38]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Daniele Castagna, 2016-08-06 04:48:06]

dcastagna@chromium.org changed reviewers:
+ ccameron@chromium.org

[Daniele Castagna, 2016-08-06 04:48:07]

Actually adding ccameron.

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/DEPS
File ui/display/types/DEPS (left):

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/DEPS#o...
ui/display/types/DEPS:4: "+ui/gfx/geometry",
On 2016/08/05 at 13:59:44, dnicoara wrote:
> Could would just add the ui/gfx:memory_buffer dependency? ui/gfx is quite
large and this doesn't need all those dependencies.

Done.

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/displa...
File ui/display/types/display_mode.h (right):

https://codereview.chromium.org/2213273002/diff/40001/ui/display/types/displa...
ui/display/types/display_mode.h:34: static gfx::BufferFormat PrimaryFormat();
On 2016/08/05 at 13:59:45, dnicoara wrote:
> This would better fit onto the DisplaySnapshot since this would be a display
related configuration.

Done.

[ccameron, 2016-08-08 19:29:10]

https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
components/display_compositor/buffer_queue.cc:215: 
I'd rather that the gfx::BufferFormat be passed in as an argument to the
BufferQueue constructor -- would that be possible instead?

[Daniele Castagna, 2016-08-08 22:08:30]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:08:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:12:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Daniele Castagna, 2016-08-08 22:12:50]

Patchset #6 (id:160001) has been deleted

[Daniele Castagna, 2016-08-08 23:04:04]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:04:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:08:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Daniele Castagna, 2016-08-08 23:12:39]

Patchset #6 (id:180001) has been deleted

[Daniele Castagna, 2016-08-08 23:16:01]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:16:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:26:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Daniele Castagna, 2016-08-09 00:34:30]

https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
components/display_compositor/buffer_queue.cc:215: 
On 2016/08/08 at 19:29:10, ccameron wrote:
> I'd rather that the gfx::BufferFormat be passed in as an argument to the
BufferQueue constructor -- would that be possible instead?

Sure, done.

Now the call to ui::DisplaySnapshot::PrimaryFormat is in
GpuSurfacelessBrowserCompositorOutputSurface ctor would you leave it there or
move it up to gpu_process_transport_factory.cc?

[ccameron, 2016-08-09 06:49:01]

On 2016/08/09 00:34:30, Daniele Castagna wrote:
>
https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
> File components/display_compositor/buffer_queue.cc (right):
> 
>
https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
> components/display_compositor/buffer_queue.cc:215: 
> On 2016/08/08 at 19:29:10, ccameron wrote:
> > I'd rather that the gfx::BufferFormat be passed in as an argument to the
> BufferQueue constructor -- would that be possible instead?
> 
> Sure, done.
> 
> Now the call to ui::DisplaySnapshot::PrimaryFormat is in
> GpuSurfacelessBrowserCompositorOutputSurface ctor would you leave it there or
> move it up to gpu_process_transport_factory.cc?

I'd move it all the way to gpu_process_transport_factory, cause that file is
where we have a big #if OS block

[Daniele Castagna, 2016-08-09 15:39:18]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 15:39:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-09 16:29:33]

On 2016/08/09 at 06:49:01, ccameron wrote:
> On 2016/08/09 00:34:30, Daniele Castagna wrote:
> >
https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
> > File components/display_compositor/buffer_queue.cc (right):
> > 
> >
https://codereview.chromium.org/2213273002/diff/140001/components/display_com...
> > components/display_compositor/buffer_queue.cc:215: 
> > On 2016/08/08 at 19:29:10, ccameron wrote:
> > > I'd rather that the gfx::BufferFormat be passed in as an argument to the
> > BufferQueue constructor -- would that be possible instead?
> > 
> > Sure, done.
> > 
> > Now the call to ui::DisplaySnapshot::PrimaryFormat is in
> > GpuSurfacelessBrowserCompositorOutputSurface ctor would you leave it there
or
> > move it up to gpu_process_transport_factory.cc?
> 
> I'd move it all the way to gpu_process_transport_factory, cause that file is
where we have a big #if OS block

Done.
PTAL.

[commit-bot: I haz the power, 2016-08-09 16:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:36:47]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-08-09 17:11:04]

lgtm, though I'd suggest leaving the Mac path as GL_RGBA/BGRA_8888, since that's
more predictable than RGB (erikchen had all sorts of issues with RGB in the
past, even if it maps to the same thing).

https://codereview.chromium.org/2213273002/diff/220001/content/browser/compos...
File content/browser/compositor/gpu_output_surface_mac.mm (right):

https://codereview.chromium.org/2213273002/diff/220001/content/browser/compos...
content/browser/compositor/gpu_output_surface_mac.mm:64:
GL_TEXTURE_RECTANGLE_ARB,
We could leave this unchanged as GL_RGBA and BGRA_8888, right?

[Daniele Castagna, 2016-08-09 21:47:15]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 21:48:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-08-09 22:25:29]

dcastagna@chromium.org changed reviewers:
+ avi@chromium.org, rjkroege@chromium.org

[Daniele Castagna, 2016-08-09 22:25:31]

+avi for content/browser/BUILD.gn
+rjkroege for services/ui/surfaces/* and ui/ozone/*

https://codereview.chromium.org/2213273002/diff/220001/content/browser/compos...
File content/browser/compositor/gpu_output_surface_mac.mm (right):

https://codereview.chromium.org/2213273002/diff/220001/content/browser/compos...
content/browser/compositor/gpu_output_surface_mac.mm:64:
GL_TEXTURE_RECTANGLE_ARB,
On 2016/08/09 at 17:11:04, ccameron wrote:
> We could leave this unchanged as GL_RGBA and BGRA_8888, right?

Yes, done.

[Avi (use Gerrit), 2016-08-09 22:57:47]

lgtm

stampity stamp

[commit-bot: I haz the power, 2016-08-09 23:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:38:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[oshima, 2016-08-10 06:29:41]

ui/display lgtm with a nit

https://codereview.chromium.org/2213273002/diff/240001/ui/display/types/displ...
File ui/display/types/display_snapshot.h (right):

https://codereview.chromium.org/2213273002/diff/240001/ui/display/types/displ...
ui/display/types/display_snapshot.h:82: // plane buffer.
nit: won't this fit in a single line?

[Daniele Castagna, 2016-08-10 16:42:20]

https://codereview.chromium.org/2213273002/diff/240001/ui/display/types/displ...
File ui/display/types/display_snapshot.h (right):

https://codereview.chromium.org/2213273002/diff/240001/ui/display/types/displ...
ui/display/types/display_snapshot.h:82: // plane buffer.
On 2016/08/10 at 06:29:41, oshima wrote:
> nit: won't this fit in a single line?

Done.

[Daniele Castagna, 2016-08-10 16:42:27]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:43:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:20:22]

Dry run: This issue passed the CQ dry run.

[rjkroege, 2016-08-10 19:01:00]

ozone + surfaces lgtm

[Daniele Castagna, 2016-08-10 20:05:35]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-08-10 20:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, oshima@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2213273002/#ps260001
(title: "Comment on a single line.")

[commit-bot: I haz the power, 2016-08-10 20:06:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:12:39]

Committed patchset #9 (id:260001)

[commit-bot: I haz the power, 2016-08-10 20:14:09]

Description was changed from

==========
ozone: Consolidate primary plane format.

Prior to this change the BufferFormat used by the primary plane
was defined in multiple places.

This CL consolidates the buffer format in DisplayMode::PrimaryFormat.

In addition RGB/BGR formats have been added where needed so that
it is now possible to switch the primary plane format from BGR to
RGB changing only the return value of DisplayMode::PrimaryFormat.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
ozone: Consolidate primary plane format.

Prior to this change the BufferFormat used by the primary plane
was defined in multiple places.

This CL consolidates the buffer format in DisplayMode::PrimaryFormat.

In addition RGB/BGR formats have been added where needed so that
it is now possible to switch the primary plane format from BGR to
RGB changing only the return value of DisplayMode::PrimaryFormat.

BUG=b/29430506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0a50f6440e5b2283ed1df4deaebb51cfa6bbe54f
Cr-Commit-Position: refs/heads/master@{#411126}
==========

[commit-bot: I haz the power, 2016-08-10 20:14:11]

Patchset 9 (id:??) landed as
https://crrev.com/0a50f6440e5b2283ed1df4deaebb51cfa6bbe54f
Cr-Commit-Position: refs/heads/master@{#411126}