Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: content/browser/ssl/ssl_policy.h

Issue 2213193005: Make SSLErrorHandler UI-thread-only and not-refcounted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove UI-thread dereference for DCHECK Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/ssl/ssl_policy.h
diff --git a/content/browser/ssl/ssl_policy.h b/content/browser/ssl/ssl_policy.h
index cdcbebeb8a2cc7765d1701e5bb7e06ba69753453..0ba7869f78c5ac94c56563b2c404ffe664db97b5 100644
--- a/content/browser/ssl/ssl_policy.h
+++ b/content/browser/ssl/ssl_policy.h
@@ -33,7 +33,7 @@ class SSLPolicy {
explicit SSLPolicy(SSLPolicyBackend* backend);
// An error occurred with the certificate in an SSL connection.
- void OnCertError(SSLErrorHandler* handler);
+ void OnCertError(std::unique_ptr<SSLErrorHandler> handler);
void DidRunInsecureContent(NavigationEntryImpl* entry,
const GURL& security_origin);
@@ -64,10 +64,6 @@ class SSLPolicy {
EXPIRED_PREVIOUS_DECISION = 1 << 2
};
- // Callback that the user chose to accept or deny the certificate.
- void OnAllowCertificate(scoped_refptr<SSLErrorHandler> handler,
- CertificateRequestResultType decision);
-
// Helper method for derived classes handling certificate errors.
//
// Options should be a bitmask combination of OnCertErrorInternalOptionsMask.
@@ -78,7 +74,8 @@ class SSLPolicy {
// certificate validation (e.g. with HTTP Strict-Transport-Security).
// EXPIRED_PREVIOUS_DECISION indicates whether a user decision had been
// previously made but the decision has expired.
- void OnCertErrorInternal(SSLErrorHandler* handler, int options_mask);
+ void OnCertErrorInternal(std::unique_ptr<SSLErrorHandler> handler,
+ int options_mask);
// If the security style of |entry| has not been initialized, then initialize
// it with the default style for its URL.
« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/browser/ssl/ssl_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698