Issue 2213193004: Revert "Return futures on Stream.cancel when possible."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2213193004: Revert "Return futures on Stream.cancel when possible." (Closed)

Created:
4 years, 4 months ago by floitsch

Modified:
4 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Return futures on Stream.cancel when possible." This reverts commit 395e7aaa696126b82862a9f75e7ebf742c354b56. Committed: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+257 lines, -552 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	5 chunks	+4 lines, -8 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View	7 chunks	+10 lines, -19 lines	0 comments	Download
M	sdk/lib/async/stream_transformers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View	4 chunks	+233 lines, -276 lines	0 comments	Download
M	tests/lib/async/stream_periodic_test.dart	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/lib/async/stream_subscription_as_future_test.dart	View	7 chunks	+6 lines, -52 lines	0 comments	Download
M	tests/lib/async/stream_subscription_cancel_test.dart	View	2 chunks	+2 lines, -186 lines	0 comments	Download

Total messages: 4 (2 generated)

floitsch

4 years, 4 months ago (2016-08-05 12:32:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
99e5328eaca7f98641a5c6e523e80b7297792817 (presubmit successful).