Add infra_libs as a bootstrap dependency.

Add infra_libs as a bootstrap dependency.

This also deletes //infra_libs - its new home is now //packages/infra_libs.

BUG=631098
R=agable@chromium.org

Committed: https://chromium.googlesource.com/infra/infra/+/53d974da55757aed619b56d661dc1e685db9c966

[Sergey Berezin, 2016-08-04 20:21:25]

PTAL

https://codereview.chromium.org/2213143002/diff/1/appengine_module/gae_event_...
File appengine_module/gae_event_mon/__init__.py (right):

https://codereview.chromium.org/2213143002/diff/1/appengine_module/gae_event_...
appengine_module/gae_event_mon/__init__.py:24: # TODO(sergeyberezin): clean up
this mess. Do not meddle with magic.
FYI: this is the ugliest thing I had to do for this CL. I'm also planning to
redeploy chromium_try_flakes just to make sure I didn't break it.

I'm going to fix this at some point: http://crbug.com/609565

[Sergey Berezin, 2016-08-04 20:21:43]

The CQ bit was checked by sergeyberezin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:21:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 20:36:08]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-08-04 21:16:51]

sergiyb@chromium.org changed reviewers:
+ sergiyb@chromium.org

[Sergiy Byelozyorov, 2016-08-04 21:16:53]

l-g-t-m w/ comment for chromium-try-flakes changes

https://codereview.chromium.org/2213143002/diff/1/appengine/chromium_try_flak...
File appengine/chromium_try_flakes/status/cq_status.py (right):

https://codereview.chromium.org/2213143002/diff/1/appengine/chromium_try_flak...
appengine/chromium_try_flakes/status/cq_status.py:26: from
infra_libs.time_functions import timestamp as tf_timestamp
please change this to

import infra_libs.time_functions.timestamp

and just add infra_libs. prefix to calls below

[Sergey Berezin, 2016-08-04 21:24:55]

Per offline conversation with sergiyb@, I'm actually going to revert that ugly
hack and just fix the symlink in third_party as I should've.

[Sergey Berezin, 2016-08-04 21:39:47]

OK, no more ugly hacks, just very boring symlink changes. This should be safe
now. PTAL.

[Sergey Berezin, 2016-08-04 21:39:57]

The CQ bit was checked by sergeyberezin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 21:39:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 21:54:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 21:54:10]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-08-04 22:07:28]

lgtm entire CL

https://codereview.chromium.org/2213143002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/third_party/time_functions/time_functions
(right):

https://codereview.chromium.org/2213143002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/third_party/time_functions/time_functions:1:
../../../../ENV/lib/python2.7/site-packages/infra_libs/time_functions
This is still very hacky... symlinking a directory that does not exist after
git-clone is non-perfect, but much better than before.

[Sergey Berezin, 2016-08-04 22:10:17]

Thanks for the review! Landing now

https://codereview.chromium.org/2213143002/diff/20001/appengine/chromium_try_...
File appengine/chromium_try_flakes/third_party/time_functions/time_functions
(right):

https://codereview.chromium.org/2213143002/diff/20001/appengine/chromium_try_...
appengine/chromium_try_flakes/third_party/time_functions/time_functions:1:
../../../../ENV/lib/python2.7/site-packages/infra_libs/time_functions
On 2016/08/04 22:07:28, Sergiy Byelozyorov wrote:
> This is still very hacky... symlinking a directory that does not exist after
> git-clone is non-perfect, but much better than before.

Yeah, but that's a problem with AppEngine now. There is a potential solution to
that as well - dnj@ is working on a deployment tool that would hopefully work
for Python GAE apps eventually too, and will avoid the need for such symlinks.

[Sergiy Byelozyorov, 2016-08-04 22:10:40]

w/ comment

https://codereview.chromium.org/2213143002/diff/20001/bootstrap/deps.pyl
File bootstrap/deps.pyl (right):

https://codereview.chromium.org/2213143002/diff/20001/bootstrap/deps.pyl#newc...
bootstrap/deps.pyl:81: 'infra_libs': {
Since infra_libs now lives in a separate repo, it would be nice to check it out
with 'fetch infra'. Can you please add it to
https://chromium.googlesource.com/infra/infra/+/master/DEPS#92

[Sergey Berezin, 2016-08-04 22:10:56]

The CQ bit was checked by sergeyberezin@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 22:14:54]

Description was changed from

==========
Add infra_libs as a bootstrap dependency.

This also deletes //infra_libs - its new home is now //packages/infra_libs.

BUG=631098
R=agable@chromium.org
==========

to

==========
Add infra_libs as a bootstrap dependency.

This also deletes //infra_libs - its new home is now //packages/infra_libs.

BUG=631098
R=agable@chromium.org

Committed:
https://chromium.googlesource.com/infra/infra/+/53d974da55757aed619b56d661dc1...
==========

[commit-bot: I haz the power, 2016-08-04 22:14:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/53d974da55757aed619b56d661dc1...

[Vadim Sh., 2016-08-04 22:38:02]

vadimsh@chromium.org changed reviewers:
+ vadimsh@chromium.org

[Vadim Sh., 2016-08-04 22:38:03]

I think it broke stuff:
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/master-man...

[Sergey Berezin, 2016-08-04 23:11:49]

On 2016/08/04 22:38:03, Vadim Sh. wrote:
> I think it broke stuff:
>
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/master-man...

Yep, fix: http://go/chromerev/482177013
Thanks!