Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2213043002:
[perf] Disable tab_switching.top_10 on mac-reference (Closed)
|
Created:
4 years, 4 months ago by petrcermak Modified:
4 years, 4 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[perf] Disable tab_switching.top_10 on mac-reference
Rationale: The benchmark is failing flakily on Mac HDD Perf (4).
BUG=634378
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
TBR=nednguyen@google.com
Committed: https://crrev.com/e033ad5b1969df84eed1e703176bb1165c7577e6
Cr-Commit-Position: refs/heads/master@{#410017}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 ========== to ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com ==========
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
PTAL. Thanks, Petr
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nednguyen@google.com changed reviewers: + aiolos@chromium.org
Kari: is Disabled('mac-reference') the correct sysntax? I can't recall this
The CQ bit was unchecked by petrcermak@chromium.org
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/04 17:37:04, nednguyen wrote:
> Kari: is Disabled('mac-reference') the correct sysntax? I can't recall this
Yes. Code for it is here:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com ========== to ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com ========== to ========== [perf] Disable tab_switching.top_10 on mac-reference Rationale: The benchmark is failing flakily on Mac HDD Perf (4). BUG=634378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq TBR=nednguyen@google.com Committed: https://crrev.com/e033ad5b1969df84eed1e703176bb1165c7577e6 Cr-Commit-Position: refs/heads/master@{#410017} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e033ad5b1969df84eed1e703176bb1165c7577e6 Cr-Commit-Position: refs/heads/master@{#410017} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
