Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2212903002: Fix files-toggle-ripple to consider RTL (Closed)

Created:
4 years, 4 months ago by harukam
Modified:
4 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix files-toggle-ripple to consider RTL BUG=617545 TEST=manually tested Committed: https://crrev.com/180fcc0314dff84e5176081eab93cf452a65023a Cr-Commit-Position: refs/heads/master@{#410555}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix files-toggle-ripple to consider RTL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
harukam
PTAL
4 years, 4 months ago (2016-08-04 08:50:29 UTC) #4
fukino
https://codereview.chromium.org/2212903002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/2212903002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode2424 ui/file_manager/file_manager/foreground/css/file_manager.css:2424: } This looks suspicious, since it results in asymmetric ...
4 years, 4 months ago (2016-08-04 09:04:48 UTC) #5
harukam
PTAL
4 years, 4 months ago (2016-08-05 01:02:39 UTC) #6
fukino
LGTM!
4 years, 4 months ago (2016-08-09 01:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212903002/20001
4 years, 4 months ago (2016-08-09 02:18:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 02:56:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:57:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/180fcc0314dff84e5176081eab93cf452a65023a
Cr-Commit-Position: refs/heads/master@{#410555}

Powered by Google App Engine
This is Rietveld 408576698