Move ChromeVox loading out of ComponentLoader.

chrome/browser/extensions/component_loader.h

Index: chrome/browser/extensions/component_loader.h
diff --git a/chrome/browser/extensions/component_loader.h b/chrome/browser/extensions/component_loader.h
index c9d8f6545e63007b3ac23eba25497241c0a172c2..476f0b60a53725165d73f3dbec2f40c6252d12ac 100644
--- a/chrome/browser/extensions/component_loader.h
+++ b/chrome/browser/extensions/component_loader.h
@@ -99,10 +99,14 @@ class ComponentLoader {
   void Reload(const std::string& extension_id);
 
 #if defined(OS_CHROMEOS)
-  // Calls |done_cb|, if not a null callback, on success.
-  // NOTE: |done_cb| is not called if the component loader is shut down
-  // during loading.
-  void AddChromeVoxExtension(const base::Closure& done_cb);
+  // Add a component extension that uses a different manifest file when
+  // this is a guest session.  Calls |done_cb| on success, unless the

[Devlin, 2016/08/04 18:06:44]

To me, this implies that it only adds it during guest sessions.  How about
something like AddComponentFromDir()?

[dmazzoni, 2016/08/04 21:35:26]

Sure, done

+  // component loader is shut down during loading.
+  void AddComponentWithGuestManifest(
+      const base::FilePath& root_directory,
+      const char* extension_id,
+      const base::Closure& done_cb);
+
   void AddChromeOsSpeechSynthesisExtension();
 #endif
 
@@ -175,18 +179,10 @@ class ComponentLoader {
   void EnableFileSystemInGuestMode(const std::string& id);
 
 #if defined(OS_CHROMEOS)
-  // Adds an extension where the manifest file is stored on the file system.
-  // |manifest_filename| can be relative to the |root_directory|.
-  void AddWithManifestFile(
-      const base::FilePath::CharType* manifest_filename,
-      const base::FilePath& root_directory,
-      const char* extension_id,
-      const base::Closure& done_cb);
-
   // Used as a reply callback by |AddWithManifestFile|.
   // Called with a |root_directory| and parsed |manifest| and invokes
   // |done_cb| after adding the extension.
-  void FinishAddWithManifestFile(
+  void FinishAddComponentWithGuestManifest(
       const base::FilePath& root_directory,
       const char* extension_id,
       const base::Closure& done_cb,