Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 221283007: Fix ninja build for Android (Closed)

Created:
6 years, 8 months ago by qiankun
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix ninja build for Android android_ninja build script can't recognize "BUILDTYPE=Release". This CL parses and sets the BUILDTYPE parameter in android_setup.sh. BUG=skia:2383 Committed: http://code.google.com/p/skia/source/detail?r=14043

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
qiankun
PTAL.
6 years, 8 months ago (2014-04-03 05:31:41 UTC) #1
epoger
Leon- can you please review this small fix? It seems harmless enough to me, although ...
6 years, 8 months ago (2014-04-03 13:48:41 UTC) #2
scroggo
Adding Derek and Mike, who know more about this script.
6 years, 8 months ago (2014-04-03 13:52:19 UTC) #3
mtklein
LGTM. Seems fine to me. I don't mind having it work this way, and I ...
6 years, 8 months ago (2014-04-03 14:26:37 UTC) #4
epoger
Since mtklein has LGed it, I'll check the box...
6 years, 8 months ago (2014-04-03 14:30:07 UTC) #5
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-03 14:30:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/221283007/1
6 years, 8 months ago (2014-04-03 14:30:14 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:48:19 UTC) #8
Message was sent while issue was closed.
Change committed as 14043

Powered by Google App Engine
This is Rietveld 408576698