Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2212813003: Clean up use of resource provider in cli (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -43 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 5 chunks +10 lines, -8 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 6 chunks +17 lines, -10 lines 0 comments Download
M pkg/analyzer_cli/test/build_mode_test.dart View 4 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-04 19:03:38 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-04 19:05:19 UTC) #3
Brian Wilkerson
4 years, 4 months ago (2016-08-04 19:31:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b47d35d7064f80be00b317bf6860c82e332e3764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698