Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2212733002: X87: Clear exceptions in Invoke instead of JSEntryStub. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Clear exceptions in Invoke instead of JSEntryStub. port cdae865436aa1039154c86baaac98b2b8a118376 (r38292) original commit message: A corresponding flag was added as well to help us find out what breaks when we do not clear pending exceptions on each JS entry. BUG= Committed: https://crrev.com/6f94976b023415d7455119b6374ff4663a19c08d Cr-Commit-Position: refs/heads/master@{#38320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-04 02:17:17 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-04 04:06:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212733002/1
4 years, 4 months ago (2016-08-04 04:08:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 04:26:39 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 04:27:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f94976b023415d7455119b6374ff4663a19c08d
Cr-Commit-Position: refs/heads/master@{#38320}

Powered by Google App Engine
This is Rietveld 408576698