Make AdaBoost the default heuristic for ReaderModeUI finch

Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658
Committed: https://crrev.com/854bee4f0a2a66eab536103cc0c59a1d941abaec
Cr-Commit-Position: refs/heads/master@{#417382}

[wychen, 2016-08-04 03:34:04]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-08-04 03:34:04]

PTAL

[mdjones, 2016-08-05 16:59:43]

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:41: return
DistillerHeuristicsType::ADABOOST_MODEL;
Is this going to skew our groups?

[wychen, 2016-08-06 07:03:22]

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:41: return
DistillerHeuristicsType::ADABOOST_MODEL;
On 2016/08/05 16:59:43, mdjones wrote:
> Is this going to skew our groups?

This is meant to be landed after we decide to roll to 100%.
Sorry for the confusion.

With the disabled group (patch set 3), as long as we name all the non-exp groups
Disabled*, the behavior should be the same.

[wychen, 2016-08-06 21:55:09]

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
File components/dom_distiller/core/experiments.cc (right):

https://codereview.chromium.org/2212663003/diff/1/components/dom_distiller/co...
components/dom_distiller/core/experiments.cc:41: return
DistillerHeuristicsType::ADABOOST_MODEL;
On 2016/08/06 07:03:22, wychen wrote:
> With the disabled group (patch set 3), as long as we name all the non-exp
groups
> Disabled*, the behavior should be the same.

OK, this is also wrong. Some users don't get finch signals, so this would need
to wait for 100% stable approval.

[wychen, 2016-08-19 21:36:26]

Description was changed from

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=
==========

to

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658
==========

[wychen, 2016-08-19 21:56:28]

We'll land this on M55.

[wychen, 2016-09-07 22:49:49]

I think it's time to land this. PTAL.

[mdjones, 2016-09-08 17:16:32]

lgtm

[wychen, 2016-09-08 19:05:10]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:05:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 20:31:18]

Description was changed from

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658
==========

to

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658
==========

[commit-bot: I haz the power, 2016-09-08 20:31:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 20:33:32]

Description was changed from

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658
==========

to

==========
Make AdaBoost the default heuristic for ReaderModeUI finch

BUG=408658

Committed: https://crrev.com/854bee4f0a2a66eab536103cc0c59a1d941abaec
Cr-Commit-Position: refs/heads/master@{#417382}
==========

[commit-bot: I haz the power, 2016-09-08 20:33:33]

Patchset 3 (id:??) landed as
https://crrev.com/854bee4f0a2a66eab536103cc0c59a1d941abaec
Cr-Commit-Position: refs/heads/master@{#417382}