Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2212643002: Removed warnings from test (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed warnings from test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M runtime/observatory/tests/service/regexp_function_test.dart View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-04 00:23:37 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-04 00:36:42 UTC) #3
cbernaschina
4 years, 4 months ago (2016-08-04 00:55:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
17bde049e0b58d5d6c6ed480fc88c1b8e774bb02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698