Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html
diff --git a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html
index 1b3cad86f6a0e14df8974c0f0c4f4d5277447754..f7e42ffcd2c68db95b38c62ecdd23cb9986977e1 100644
--- a/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html
+++ b/runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/json_view.html
@@ -1,33 +1,11 @@
-<head>
- <link rel="import" href="observatory_element.html">
-</head>
+<link rel="import" href="nav_bar.html">
+<link rel="import" href="observatory_element.html">
<polymer-element name="json-view" extends="observatory-element">
<template>
- <template bind if="{{ valueType == 'Primitive' }}">
- <span>{{primitiveString}}</span>
- </template>
- <template bind if="{{ valueType == 'List' }}">
- <table class="table table-condensed table-bordered">
- <caption class="text-left">List, {{list.length}}</caption>
- <tbody>
- <tr template repeat="{{item in list)}}">
- <th>{{counter}}</th>
- <td><json-view json="{{item}}"></json-view></td>
- </tr>
- </tbody>
- </table>
- </template>
- <template if="{{ valueType == 'Map' }}">
- <table class="table table-condensed table-bordered">
- <caption class="text-left">Map, {{keys.length}}</caption>
- <tbody>
- <tr template repeat="{{key in keys}}">
- <th>{{key}}</th>
- <td><json-view json="{{value(key)}}"></json-view></td>
- </tr>
- </tbody>
- </table>
- </template>
+ <nav-bar>
+ <top-nav-menu last="{{ true }}"></top-nav-menu>
+ </nav-bar>
+ <pre>{{ mapAsString }}</pre>
</template>
<script type="application/dart" src="json_view.dart"></script>
</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698