Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.dart

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/script_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/script_view.dart b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
index 687f07885d67de9fc24a3746a9059e181f16eb9c..5971488c1f4c2d41583cd8c032cf99b9cf68ed5c 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/script_view.dart
@@ -5,10 +5,11 @@
library script_view_element;
import 'observatory_element.dart';
+import 'package:observatory/elements.dart';
import 'package:observatory/service.dart';
import 'package:polymer/polymer.dart';
-/// Displays an Error response.
+/// Displays an Script response.
@CustomTag('script-view')
class ScriptViewElement extends ObservatoryElement {
@published Script script;
@@ -24,31 +25,9 @@ class ScriptViewElement extends ObservatoryElement {
script.load();
}
- void _triggerHitRefresh() {
- notifyPropertyChange(#hitsStyle, 0, 1);
- }
-
showCoverageChanged(oldValue) {
- _triggerHitRefresh();
- }
-
- static const hitStyleNone = 'min-width:32px;';
- static const hitStyleExecuted = 'min-width:32px;background-color:green';
- static const hitStyleNotExecuted = 'min-width:32px;background-color:red';
-
- @observable String hitsStyle(ScriptLine line) {
- if ((script == null) || !showCoverage) {
- return hitStyleNone;
- }
- var hit = script.hits[line.line];
- if (hit == null) {
- return hitStyleNone;
- }
- if (hit == 0) {
- return hitStyleNotExecuted;
- }
- assert(hit > 0);
- return hitStyleExecuted;
+ ScriptInsetElement sie = shadowRoot.querySelector('#scriptInset');
+ sie.coverage = showCoverage;
}
void refresh(var done) {
@@ -56,9 +35,6 @@ class ScriptViewElement extends ObservatoryElement {
}
void refreshCoverage(var done) {
- script.isolate.refreshCoverage().then((_) {
- _triggerHitRefresh();
- done();
- });
+ script.isolate.refreshCoverage().whenComplete(done);
}
}

Powered by Google App Engine
This is Rietveld 408576698