runtime/bin/vmservice/client/lib/src/elements/script_view.html - Issue 221263002: Miscellaneous Observatory UI improvements

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/script_view.html

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« runtime/bin/vmservice/client/lib/src/elements/script_inset.html ('K') | « runtime/bin/vmservice/client/lib/src/elements/script_view.dart ('k') | runtime/bin/vmservice/client/lib/src/elements/service_view.dart » ('j') | runtime/bin/vmservice/client/lib/src/service/object.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/script_view.html

diff --git a/runtime/bin/vmservice/client/lib/src/elements/script_view.html b/runtime/bin/vmservice/client/lib/src/elements/script_view.html

index ef6b4a7df06911d05df615aece04e63b710371b8..e3b3a102f3c5247ef426d294108649c50d811de2 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/script_view.html

+++ b/runtime/bin/vmservice/client/lib/src/elements/script_view.html

@@ -1,9 +1,31 @@

<head>

+ <link rel="import" href="script_inset.html">

</head>

<polymer-element name="script-view" extends="observatory-element">

+ <style>

+ .content {

+ padding-left: 10%;

+ font: 400 14px 'Montserrat', sans-serif;

+ }

+ h1 {

+ font: 400 18px 'Montserrat', sans-serif;

+ }

+ .memberList {

+ display: table;

+ }

+ .memberItem {

+ display: table-row;

+ }

+ .memberName, .memberValue {

+ display: table-cell;

+ vertical-align: top;

+ padding: 3px 0 3px 1em;

+ font: 400 14px 'Montserrat', sans-serif;

+ }

turnidge 2014/04/01 19:42:48 Do we use any of these styles on this page? If no

Cutch 2014/04/02 18:26:52 Done.

+ </style>

<nav-bar>

<top-nav-menu></top-nav-menu>

<isolate-nav-menu isolate="{{ script.isolate }}">

@@ -20,22 +42,9 @@

</nav-refresh>

</nav-bar>

- <div class="row">

- <div class="col-md-8 col-md-offset-2">

- <div class="panel-heading">Script source for: {{ script.name }}</div>

- <div class="panel-body">

- <table style="width:100%">

- <tbody>

- <tr template repeat="{{ line in script.lines }}">

- <td style="{{ hitsStyle(line) }}"> </td>

- <td style="font-family: consolas, courier, monospace;font-size: 1em;line-height: 1.2em;white-space: nowrap;">{{line.line}}</td>

- <td width="99%" style="font-family: consolas, courier, monospace;font-size: 1em;line-height: 1.2em;white-space: pre;">{{line.text}}</td>

- </tr>

- </tbody>

- </table>

- </div>

+ <script-inset id="scriptInset" script="{{ script }}" pos="{{ script.firstTokenPos }}" endPos="{{ script.lastTokenPos }}">

+ <h1>script {{ script.name }}</h1>

+ </script-inset>

</template>

</polymer-element>