runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart - Issue 221263002: Miscellaneous Observatory UI improvements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

index 14391e1d0f0bc75cc0570184b5e67439869c6a88..bbde39b41af35414ef2f842a00add9377bb26896 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

@@ -234,6 +234,9 @@ class IsolateProfileElement extends ObservatoryElement {

}

@observable void toggleExpanded(Event e, var detail, Element target) {

turnidge 2014/04/01 19:42:48 A comment here would make this more clear.

Cutch 2014/04/02 18:26:52 Done.

+ if ((e.target.id != 'expand') && (e.target != target)) {

+ return;

+ }

var row = target.parent;

if (row is TableRowElement) {

// Subtract 1 to get 0 based indexing.