Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/view_model.dart

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/view_model.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/view_model.dart b/runtime/bin/vmservice/client/lib/src/app/view_model.dart
index dda6c81ab8dc743269607d1fd861e3d40d6e691b..0ef0169e09574f179212362cda1eda969015f171 100644
--- a/runtime/bin/vmservice/client/lib/src/app/view_model.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/view_model.dart
@@ -9,6 +9,9 @@ abstract class TableTreeRow extends Observable {
@observable final int depth;
@observable final List<TableTreeRow> children = new List<TableTreeRow>();
@observable final List<String> columns = [];
+ static const arrowRight = '\u2192';
+ static const arrowDownRight = '\u21b3';
+ @observable String expander = arrowRight;
turnidge 2014/04/01 19:42:48 I recommend deleting expander here and instead usi
Cutch 2014/04/02 18:26:52 I agree with you in spirit. But putting this into
TableTreeRow(TableTreeRow parent) :
parent = parent,
@@ -22,8 +25,10 @@ abstract class TableTreeRow extends Observable {
if (changed) {
// If the state has changed, fire callbacks.
if (_expanded) {
+ expander = arrowDownRight;
onShow();
} else {
+ expander = arrowRight;
onHide();
}
}

Powered by Google App Engine
This is Rietveld 408576698