runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html - Issue 221263002: Miscellaneous Observatory UI improvements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html

Issue 221263002: Miscellaneous Observatory UI improvements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart ('K') | « runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart ('k') | runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html » ('j') | runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <link rel="import" href="code_ref.html">	2 <link rel="import" href="code_ref.html">

3 <link rel="import" href="nav_bar.html">	3 <link rel="import" href="nav_bar.html">

4 <link rel="import" href="observatory_element.html">	4 <link rel="import" href="observatory_element.html">

5 <link rel="import" href="sliding_checkbox.html">	5 <link rel="import" href="sliding_checkbox.html">

6 </head>	6 </head>

7 <polymer-element name="isolate-profile" extends="observatory-element">	7 <polymer-element name="isolate-profile" extends="observatory-element">

8 <template>	8 <template>

9 <nav-bar>	9 <nav-bar>

10 <top-nav-menu></top-nav-menu>	10 <top-nav-menu></top-nav-menu>

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 <th>Method</th>	74 <th>Method</th>

75 <th>Caller</th>	75 <th>Caller</th>

76 <th>Exclusive</th>	76 <th>Exclusive</th>

77 </tr>	77 </tr>

78 </thead>	78 </thead>

79 <tbody>	79 <tbody>

80 <tr template repeat="{{row in tree.rows }}" style="{{}}">	80 <tr template repeat="{{row in tree.rows }}" style="{{}}">

81 <td on-click="{{toggleExpanded}}"	81 <td on-click="{{toggleExpanded}}"

82 class="{{ coloring(row) }}"	82 class="{{ coloring(row) }}"

83 style="{{ padding(row) }}">	83 style="{{ padding(row) }}">

	84 <span id="expand" style="cursor: pointer;">{{ row.expander }}</spa n>
	turnidge 2014/04/01 19:42:48 Redundant comment from me: drop row.expander here Redundant comment from me: drop row.expander here and instead have a template-if on "expanded". It will keep your ui choices in the html file.
84 <code-ref ref="{{ row.code }}"></code-ref>	85 <code-ref ref="{{ row.code }}"></code-ref>

85 </td>	86 </td>

86 <td class="{{ coloring(row) }}">{{row.columns[0]}}</td>	87 <td class="{{ coloring(row) }}">{{row.columns[0]}}</td>

87 <td class="{{ coloring(row) }}">{{row.columns[1]}}</td>	88 <td class="{{ coloring(row) }}">{{row.columns[1]}}</td>

88 </tr>	89 </tr>

89 </tbody>	90 </tbody>

90 </table>	91 </table>

91 </div>	92 </div>

92 </template>	93 </template>

93 <script type="application/dart" src="isolate_profile.dart"></script>	94 <script type="application/dart" src="isolate_profile.dart"></script>

94 </polymer-element>	95 </polymer-element>

OLD	NEW