Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2212543002: Disable scroll anchoring if the user engages in a drag motion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove irrelevant comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2011 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 // Returns true if the scroller adjusts the scroll position to compensate 281 // Returns true if the scroller adjusts the scroll position to compensate
282 // for layout movements (bit.ly/scroll-anchoring). 282 // for layout movements (bit.ly/scroll-anchoring).
283 virtual bool shouldPerformScrollAnchoring() const { return false; } 283 virtual bool shouldPerformScrollAnchoring() const { return false; }
284 284
285 // Need to promptly let go of owned animator objects. 285 // Need to promptly let go of owned animator objects.
286 EAGERLY_FINALIZE(); 286 EAGERLY_FINALIZE();
287 DECLARE_VIRTUAL_TRACE(); 287 DECLARE_VIRTUAL_TRACE();
288 288
289 virtual void clearScrollAnimators(); 289 virtual void clearScrollAnimators();
290 290
291 virtual void setUserMayHaveDragged(bool dragged) {};
292
291 protected: 293 protected:
292 ScrollableArea(); 294 ScrollableArea();
293 295
294 ScrollbarOrientation scrollbarOrientationFromDirection(ScrollDirectionPhysic al) const; 296 ScrollbarOrientation scrollbarOrientationFromDirection(ScrollDirectionPhysic al) const;
295 float scrollStep(ScrollGranularity, ScrollbarOrientation) const; 297 float scrollStep(ScrollGranularity, ScrollbarOrientation) const;
296 298
297 void setScrollOrigin(const IntPoint&); 299 void setScrollOrigin(const IntPoint&);
298 void resetScrollOriginChanged() { m_scrollOriginChanged = false; } 300 void resetScrollOriginChanged() { m_scrollOriginChanged = false; }
299 301
300 // Needed to let the animators call scrollPositionChanged. 302 // Needed to let the animators call scrollPositionChanged.
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 // vertical-lr / ltr NO NO 344 // vertical-lr / ltr NO NO
343 // vertical-lr / rtl NO YES 345 // vertical-lr / rtl NO YES
344 // vertical-rl / ltr YES NO 346 // vertical-rl / ltr YES NO
345 // vertical-rl / rtl YES YES 347 // vertical-rl / rtl YES YES
346 IntPoint m_scrollOrigin; 348 IntPoint m_scrollOrigin;
347 }; 349 };
348 350
349 } // namespace blink 351 } // namespace blink
350 352
351 #endif // ScrollableArea_h 353 #endif // ScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698