Issue 221253002: DevTools: move off WebInspector.css/domModel in sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221253002: DevTools: move off WebInspector.css/domModel in sidebars. (Closed)

Created:
6 years, 8 months ago by pfeldman

Modified:
6 years, 8 months ago

Reviewers:
lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: move off WebInspector.css/domModel in sidebars. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170595

Patch Set 1 #

Patch Set 2 : Review comment addressed. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -80 lines)			Patch
M	Source/devtools/front_end/ElementsPanel.js	View		3 chunks	+13 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/MetricsSidebarPane.js	View	1	8 chunks	+41 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/PlatformFontsSidebarPane.js	View		3 chunks	+20 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/StylesSidebarPane.js	View		33 chunks	+70 lines, -54 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

lushnikov

On 2014/04/01 17:49:07, lushnikov wrote: > lgtm please use cq

6 years, 8 months ago (2014-04-01 17:49:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/221253002/20001

6 years, 8 months ago (2014-04-01 17:50:06 UTC) #5

Message was sent while issue was closed.

Change committed as 170595

Expand Messages | Collapse Messages