Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2212483002: Respin: Define printer configuration objects for Chrome OS. (Closed)

Created:
4 years, 4 months ago by skau
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, xdai1
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Respin: Define printer configuration objects for Chrome OS. Models will represent complete information required to setup a printer. They will be stored in local storage until sync can be implemented with the Chrome Sync team. BUG=616853 TEST=Unit tests for all object translation code. Original CL: https://codereview.chromium.org/2161933003/ Original code released a pointer without cleaning it up in printer_configuration.cc. This is fixed by changing it to a get. Committed: https://crrev.com/65455b5a016186bd50b135f2b6f7d803d2a67445 Cr-Commit-Position: refs/heads/master@{#409608}

Patch Set 1 #

Patch Set 2 : fix memory leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -1 line) Patch
A chrome/browser/chromeos/printing/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/printing/printer_pref_manager.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/printing/printer_pref_manager.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
A chromeos/printing/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chromeos/printing/printer_configuration.h View 1 chunk +104 lines, -0 lines 0 comments Download
A chromeos/printing/printer_configuration.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chromeos/printing/printer_translator.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chromeos/printing/printer_translator.cc View 1 chunk +135 lines, -0 lines 0 comments Download
A chromeos/printing/printer_translator_unittest.cc View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
skau
This is a respin. See comment for the change. I can't replicate the test failure ...
4 years, 4 months ago (2016-08-03 18:15:35 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-03 18:16:44 UTC) #5
xdai1
lgtm
4 years, 4 months ago (2016-08-03 18:18:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2212483002/20001
4 years, 4 months ago (2016-08-03 20:12:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 20:16:53 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:19:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65455b5a016186bd50b135f2b6f7d803d2a67445
Cr-Commit-Position: refs/heads/master@{#409608}

Powered by Google App Engine
This is Rietveld 408576698